fix(http): enable DNS-rebinding protection by default#153
Open
SVilgelm wants to merge 1 commit into
Open
Conversation
Default dns_rebinding_protection to true and warn at startup when neither allowed_hosts nor allowed_origins is configured. Set it to false to opt out. Assisted-By: Claude Opus 4.7 <noreply@anthropic.com> Signed-off-by: Sergey Vilgelm <sergey@vilgelm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
DNS-rebinding protection defaulted to
false, leaving local servers exposed to browser-based DNS-rebinding attacks unless explicitly enabled. The MCP spec strongly recommendsOrigin/Hostvalidation, so it is now on by default with an explicit opt-out, and the server logs a startup warning when protection is enabled but noallowed_hosts/allowed_originsare configured.🔍 Related Issues
✨ Changes Made
HyperServerOptions::dns_rebinding_protectiontotrue.