Skip to content

rustfmt tests#3529

Merged
bors merged 8 commits into
rust-lang:masterfrom
matthiaskrgr:rustfmt_tests
Dec 12, 2018
Merged

rustfmt tests#3529
bors merged 8 commits into
rust-lang:masterfrom
matthiaskrgr:rustfmt_tests

Conversation

@matthiaskrgr
Copy link
Copy Markdown
Member

@matthiaskrgr matthiaskrgr commented Dec 11, 2018

also fails CI if tests turn out to not be formatted properly.

sinkuu
sinkuu reviewed Dec 11, 2018
View reviewed changes
Comment thread tests/ui/attrs.rs
phansch
phansch suggested changes Dec 11, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@phansch phansch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from what @sinkuu said, it would be good to include the subdirectories, too. Otherwise this LGTM.

Comment thread ci/base-tests.sh
Comment thread tests/ui/decimal_literal_representation.rs Outdated
Comment thread tests/ui/decimal_literal_representation.rs Outdated
Comment thread tests/ui/implicit_hasher.rs Outdated
Comment thread tests/ui/swap.rs Outdated
@phansch phansch added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Dec 11, 2018
@matthiaskrgr matthiaskrgr added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Dec 11, 2018
@oli-obk
Copy link
Copy Markdown
Contributor

oli-obk commented Dec 11, 2018

appveyor is unhappy

@phansch
Copy link
Copy Markdown
Contributor

phansch commented Dec 11, 2018

@oli-obk yup, that's probably going to be fixed by rust-lang-deprecated/failure#279

@matthiaskrgr
Copy link
Copy Markdown
Member Author

matthiaskrgr commented Dec 11, 2018

@bors try

@bors
Copy link
Copy Markdown
Contributor

bors commented Dec 11, 2018

⌛ Trying commit 36266b3 with merge 301d44a...

bors added a commit that referenced this pull request Dec 11, 2018
@bors
Auto merge of #3529 - matthiaskrgr:rustfmt_tests, r=<try>
301d44a 
rustfmt tests

also fails CI if tests turn out to not be formatted properly.
@matthiaskrgr
Copy link
Copy Markdown
Member Author

matthiaskrgr commented Dec 11, 2018

./ci/base-tests.sh: line 44: [: missing ]
I should check that out

@bors
Copy link
Copy Markdown
Contributor

bors commented Dec 12, 2018

☀️ Test successful - status-appveyor, status-travis
State: approved= try=True

@phansch
Copy link
Copy Markdown
Contributor

phansch commented Dec 12, 2018

@bors r+

@bors
Copy link
Copy Markdown
Contributor

bors commented Dec 12, 2018

📌 Commit 36266b3 has been approved by phansch

@bors
Copy link
Copy Markdown
Contributor

bors commented Dec 12, 2018

⌛ Testing commit 36266b3 with merge e2608fc...

bors added a commit that referenced this pull request Dec 12, 2018
@bors
Auto merge of #3529 - matthiaskrgr:rustfmt_tests, r=phansch
e2608fc 
rustfmt tests

also fails CI if tests turn out to not be formatted properly.
@bors
Copy link
Copy Markdown
Contributor

bors commented Dec 12, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: phansch
Pushing e2608fc to master...

@bors bors merged commit 36266b3 into rust-lang:master Dec 12, 2018
This was referenced Dec 12, 2018
Closed
Merged
Closed
This was referenced Dec 12, 2018
Merged
Merged
@phansch phansch mentioned this pull request Dec 12, 2018
Merged
@matthiaskrgr
Copy link
Copy Markdown
Member Author

matthiaskrgr commented Dec 12, 2018

The fact that CI was green while there was a syntax error in the script is actually quite concerning...
I'll look into this.

@mati865
Copy link
Copy Markdown
Member

mati865 commented Dec 12, 2018

I'd didn't exit because it was told not to exit on error

rust-clippy/ci/base-tests.sh

Line 35 in 921d4da

set +ex

@matthiaskrgr matthiaskrgr mentioned this pull request Dec 12, 2018
Merged
bors added a commit that referenced this pull request Dec 12, 2018
@bors
Auto merge of #3537 - matthiaskrgr:fix_script_2, r=matthiaskrgr
f5d6aca 
base-tests: don't print all commands to stdout during the loop

Fixes thinko in #3529
@matthiaskrgr
Copy link
Copy Markdown
Member Author

matthiaskrgr commented Dec 12, 2018

Fixed via #3537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sinkuu sinkuu sinkuu left review comments

@phansch phansch phansch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matthiaskrgr @oli-obk @phansch @bors @mati865 @sinkuu