Add suggestion for explicit_write lint#3450
Merged
bors merged 7 commits intoDec 12, 2018
Merged
Conversation
phansch
commented
Nov 23, 2018
phansch
changed the title
phansch
added
the
S-waiting-on-author
phansch
commented
Nov 23, 2018
Contributor
Author
phansch
left a comment
phansch
left a comment
There was a problem hiding this comment.
need to fix one leftover debug variable name
phansch
force-pushed
the
structured_sugg_for_explicit_write
branch
2 times, most recently
from
7fe226f to
13819ce
Compare
phansch
changed the title
phansch
added
S-waiting-on-review
detrumi
reviewed
Nov 28, 2018
| }; | ||
|
|
||
| // We need to remove the last trailing newline from the string because the | ||
| // underlying `fmt::write` function doesn't know wether `println!` or `print!` was |
detrumi
reviewed
Nov 28, 2018
| // used. | ||
| let mut write_output: String = write_output.to_string(); | ||
| if write_output.ends_with('\n') { | ||
| write_output.truncate(write_output.len() - 1) |
Contributor
There was a problem hiding this comment.
How about write_output.pop()?
detrumi
reviewed
Nov 28, 2018
| // We need to remove the last trailing newline from the string because the | ||
| // underlying `fmt::write` function doesn't know wether `println!` or `print!` was | ||
| // used. | ||
| let mut write_output: String = write_output_string(write_args).unwrap(); |
Contributor
There was a problem hiding this comment.
I'm not sure if this function can fail on some inputs, but if there are cases where this fails, it should probably fall back to not using a suggestion. Otherwise, maybe expect() would be better?
phansch
force-pushed
the
structured_sugg_for_explicit_write
branch
from
b3d41bf to
c84a17d
Compare
phansch
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Fix typo * Handle None value instead of using `unwrap()` * `pop()` instead of `x.truncate(x.len() - 1)`
phansch
force-pushed
the
structured_sugg_for_explicit_write
branch
from
0933b7a to
194acaf
Compare
flip1995
approved these changes
Dec 12, 2018
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
travis is currently failing (https://travis-ci.org/rust-lang/rust-clippy/jobs/467013498#L152). I'm working on a fix. If travis is working again r=me.
Member
|
@bors rollup |
Member
|
Let's queue this @bors r+ |
Contributor
|
📌 Commit 194acaf has been approved by |
bors
added a commit
that referenced
this pull request
Dec 12, 2018
…lip1995 Add suggestion for explicit_write lint Closes #2083
Contributor
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2083