Skip to content

Fix on_* return value of ripper translator #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eregon merged 1 commit into from
Jan 20, 2026
+40 −6
Merged

Fix on_* return value of ripper translator #3865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/prism/translation/ripper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3446,12 +3446,12 @@ def bounds(location)

# :stopdoc:
def _dispatch_0; end
def _dispatch_1(_); end
def _dispatch_2(_, _); end
def _dispatch_3(_, _, _); end
def _dispatch_4(_, _, _, _); end
def _dispatch_5(_, _, _, _, _); end
def _dispatch_7(_, _, _, _, _, _, _); end
def _dispatch_1(arg); arg end
def _dispatch_2(arg, _); arg end
def _dispatch_3(arg, _, _); arg end
def _dispatch_4(arg, _, _, _); arg end
def _dispatch_5(arg, _, _, _, _); arg end
def _dispatch_7(arg, _, _, _, _, _, _); arg end
Comment on lines 3448 to +3454
Copy link
Member

@eregon eregon Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it's the same as https://github.com/ruby/ruby/blob/d225bb8b464e4e03d2eb6c09ef15adf727af9e2b/ext/ripper/lib/ripper/core.rb#L33-L42

Copy link
Member

@eregon eregon Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why we didn't/don't just copy that part from upstream.
Maybe the unused variables cause warnings?

Copy link
Collaborator Author

@Earlopain Earlopain Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice. I was mostly just guessing but this makes it pretty clear.

# :startdoc:

#
Expand Down
34 changes: 34 additions & 0 deletions test/prism/ruby/ripper_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,40 @@ class RipperTest < TestCase
define_method("#{fixture.test_name}_lex") { assert_ripper_lex(fixture.read) }
end

module Events
attr_reader :events

def initialize(...)
super
@events = []
end

Prism::Translation::Ripper::PARSER_EVENTS.each do |event|
define_method(:"on_#{event}") do |*args|
@events << [event, *args]
super(*args)
end
end
end

class RipperEvents < Ripper
include Events
end

class PrismEvents < Translation::Ripper
include Events
end

def test_events
source = "1 rescue 2"
ripper = RipperEvents.new(source)
prism = PrismEvents.new(source)
ripper.parse
prism.parse
# This makes sure that the content is the same. Ordering is not correct for now.
assert_equal(ripper.events.sort, prism.events.sort)
end

def test_lexer
lexer = Translation::Ripper::Lexer.new("foo")
expected = [[1, 0], :on_ident, "foo", Translation::Ripper::EXPR_CMDARG]
Expand Down