Fix on_* return value of ripper translator
#3865
Merged
+40
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Somewhat unsure about this fix but it seems to work very well. |
eregon
reviewed
Jan 20, 2026
eregon
reviewed
Jan 20, 2026
eregon
reviewed
Jan 20, 2026
Comment on lines
3448
to
+3454
| def _dispatch_0; end | ||
| def _dispatch_1(_); end | ||
| def _dispatch_2(_, _); end | ||
| def _dispatch_3(_, _, _); end | ||
| def _dispatch_4(_, _, _, _); end | ||
| def _dispatch_5(_, _, _, _, _); end | ||
| def _dispatch_7(_, _, _, _, _, _, _); end | ||
| def _dispatch_1(arg); arg end | ||
| def _dispatch_2(arg, _); arg end | ||
| def _dispatch_3(arg, _, _); arg end | ||
| def _dispatch_4(arg, _, _, _); arg end | ||
| def _dispatch_5(arg, _, _, _, _); arg end | ||
| def _dispatch_7(arg, _, _, _, _, _, _); arg end |
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
I wonder why we didn't/don't just copy that part from upstream.
Maybe the unused variables cause warnings?
Collaborator
Author
There was a problem hiding this comment.
Ah, nice. I was mostly just guessing but this makes it pretty clear.
You're supposed to return the first argument. ```rb # Before [[:stmts_new], [:rescue_mod, nil, nil], [:stmts_add, nil, nil], [:program, nil]] # After [[:stmts_new], [:rescue_mod, "1", "2"], [:stmts_add, nil, "1"], [:program, nil]] ``` The correct result would be: `[[:rescue_mod, "1", "2"], [:stmts_new], [:stmts_add, nil, "1"], [:program, nil]]` But the order depends on the prism AST so it seems very difficult to match.
Earlopain
force-pushed
the
ripper-events-return-value
branch
from
6aa3a04 to
94e0107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You're supposed to return the first argument.
The correct result would be:
[[:rescue_mod, "1", "2"], [:stmts_new], [:stmts_add, nil, "1"], [:program, nil]]But the order depends on the prism AST so it seems very difficult to match.
Ref: #3838