Minor edit, "message_generation" instead "genmsg" #12
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since catkin_create_pkg uses Package.xml format 2, some of the mentioned codelines are already uncommented, and I changed the code to reflect this.
Author
|
Second commit, after also changing the explanation, regarding changes in code that is already un-commented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the "message_generation" dependency vs the "genmsg" dependency.
I noticed a minor inconsistency here, compared to what is stated in the previous page: CreatingMsgAndSrv. Found about issue #6 and decided to try to contribute a small edit.
I guess I'll include @jack-oquin as he's the one responsible for issue #6..