Skip to content

fix columns_view in table settings #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 2 commits into from
Jan 22, 2026
Merged

fix columns_view in table settings #1519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14489bb
Refactor table settings E2E tests to improve readability and maintain…
Artuomka Jan 22, 2026
1916a49
Merge branch 'main' into backend_table_settings_rework
Artuomka Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions backend/src/entities/table-settings/application/data-structures/create-table-settings.ds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,4 +77,7 @@ export class CreateTableSettingsDs {

@ApiProperty({ required: false })
ordering_field?: string;

@ApiProperty({ isArray: true, type: 'string', required: false })
columns_view?: Array<string>;
}
25 changes: 13 additions & 12 deletions backend/src/entities/table-settings/common-table-settings/dto/create-table-settings.dto.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,17 @@ import { CustomFieldsEntity } from '../../../custom-field/custom-fields.entity.j
import { TableWidgetEntity } from '../../../widget/table-widget.entity.js';

export class CreateTableSettingsDto {
connection_id: string;
table_name: string;
display_name: string;
search_fields: string[];
excluded_fields: string[];
identification_fields: string[];
identity_column;
readonly_fields: string[];
sortable_by: string[];
autocomplete_columns: string[];
custom_fields?: CustomFieldsEntity[];
table_widgets?: TableWidgetEntity[];
connection_id: string;
table_name: string;
display_name: string;
search_fields: string[];
excluded_fields: string[];
identification_fields: string[];
identity_column;
readonly_fields: string[];
sortable_by: string[];
autocomplete_columns: string[];
custom_fields?: CustomFieldsEntity[];
table_widgets?: TableWidgetEntity[];
columns_view?: string[];
}
4 changes: 4 additions & 0 deletions backend/src/entities/table-settings/common-table-settings/table-settings.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ export class TableSettingsController {
@Body('list_fields') list_fields: string[],
@Body('ordering') ordering: string,
@Body('ordering_field') ordering_field: string,
@Body('columns_view') columns_view: string[],
@UserId() userId: string,
@MasterPassword() masterPwd: string,
): Promise<FoundTableSettingsDs> {
Expand Down Expand Up @@ -147,6 +148,7 @@ export class TableSettingsController {
list_fields: list_fields,
ordering: ordering,
ordering_field: ordering_field,
columns_view: columns_view,
};

const errors = this.validateParameters(inputData);
Expand Down Expand Up @@ -195,6 +197,7 @@ export class TableSettingsController {
@Body('list_fields') list_fields: string[],
@Body('ordering') ordering: string,
@Body('ordering_field') ordering_field: string,
@Body('columns_view') columns_view: string[],
@UserId() userId: string,
@MasterPassword() masterPwd: string,
): Promise<FoundTableSettingsDs> {
Expand Down Expand Up @@ -223,6 +226,7 @@ export class TableSettingsController {
list_per_page,
ordering,
ordering_field,
columns_view,
};

const errors = this.validateParameters(inputData);
Expand Down
2 changes: 2 additions & 0 deletions ...rc/entities/table-settings/common-table-settings/utils/build-new-table-settings-entity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export function buildNewTableSettingsEntity(
list_fields,
ordering,
ordering_field,
columns_view,
} = settings;
newSettings.connection_id = connection;
newSettings.display_name = display_name;
Expand All @@ -57,5 +58,6 @@ export function buildNewTableSettingsEntity(
newSettings.list_fields = list_fields;
newSettings.ordering = ordering as QueryOrderingEnum;
newSettings.ordering_field = ordering_field;
newSettings.columns_view = columns_view;
return newSettings;
}
Loading
Loading