Skip to content

Conversation

@Artuomka
Copy link
Collaborator

…ability; add tests for personal table settings and ensure proper handling of missing fields and invalid data types.

…ability; add tests for personal table settings and ensure proper handling of missing fields and invalid data types.
Copilot AI review requested due to automatic review settings January 22, 2026 10:17
@Artuomka Artuomka enabled auto-merge January 22, 2026 10:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes the columns_view field in table settings by ensuring it is properly passed from the controller to the persistence layer. It also adds comprehensive tests for personal table settings functionality with the columns_view field.

Changes:

  • Added columns_view parameter extraction in table settings controller endpoints
  • Included columns_view in the data transfer objects (DTOs) and data structures
  • Updated the table settings entity builder to save the columns_view field
  • Added tests verifying the priority of personal table settings columns_view over common table settings
  • Includes formatting changes (indentation from spaces to tabs) in test files

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
backend/test/ava-tests/saas-tests/table-settings-e2e.test.ts Added 3 new tests for columns_view priority logic and reformatted existing tests
backend/test/ava-tests/non-saas-tests/non-saas-table-settings-e2e.test.ts Added 3 new tests for columns_view priority and removed inline comments from existing tests
backend/src/entities/table-settings/common-table-settings/utils/build-new-table-settings-entity.ts Added extraction and assignment of columns_view field
backend/src/entities/table-settings/common-table-settings/table-settings.controller.ts Added columns_view parameter to POST and PUT endpoints
backend/src/entities/table-settings/common-table-settings/dto/create-table-settings.dto.ts Added columns_view field to DTO and reformatted to use tabs
backend/src/entities/table-settings/application/data-structures/create-table-settings.ds.ts Added columns_view field with API property decorator

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Artuomka Artuomka merged commit e46655c into main Jan 22, 2026
19 checks passed
@Artuomka Artuomka deleted the backend_table_settings_rework branch January 22, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants