Skip to content

Add new parameters for table settings creation: list_per_page, list_fields, ordering, and ordering_field #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 1 commit into from
Jan 21, 2026
Merged

Add new parameters for table settings creation: list_per_page, list_fields, ordering, and ordering_field #1516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions backend/src/entities/table-settings/common-table-settings/table-settings.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,10 @@ export class TableSettingsController {
@Body('icon') icon: string,
@Body('allow_csv_export') allow_csv_export: boolean,
@Body('allow_csv_import') allow_csv_import: boolean,
@Body('list_per_page') list_per_page: number,
@Body('list_fields') list_fields: string[],
@Body('ordering') ordering: string,
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ordering parameter is declared as string, but based on the entity definition and usage in the codebase, it should be typed as QueryOrderingEnum | null. The entity uses QueryOrderingEnum (which has values 'ASC' or 'DESC'), and the data structure also defines it as optional. Consider updating the type to ensure type safety and consistency with the rest of the codebase.

Copilot uses AI. Check for mistakes.
@Body('ordering_field') ordering_field: string,
@UserId() userId: string,
@MasterPassword() masterPwd: string,
): Promise<FoundTableSettingsDs> {
Expand All @@ -215,6 +219,10 @@ export class TableSettingsController {
icon: icon,
allow_csv_export: allow_csv_export,
allow_csv_import: allow_csv_import,
list_fields,
list_per_page,
ordering,
ordering_field,
};

const errors = this.validateParameters(inputData);
Expand Down
Loading