Add new parameters for table settings creation: list_per_page, list_fields, ordering, and ordering_field #1516
Conversation
…ields, ordering, and ordering_field
There was a problem hiding this comment.
Pull request overview
This pull request adds support for four new parameters in the table settings update endpoint: list_per_page, list_fields, ordering, and ordering_field. These parameters enable clients to configure pagination, field selection, and sorting behavior for table data.
Changes:
- Added four new
@Bodyparameters to theupdateSettingsmethod in the table settings controller - Added the new parameters to the
inputDataobject that's passed to the use case
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @Body('allow_csv_import') allow_csv_import: boolean, | ||
| @Body('list_per_page') list_per_page: number, | ||
| @Body('list_fields') list_fields: string[], | ||
| @Body('ordering') ordering: string, |
There was a problem hiding this comment.
The ordering parameter is declared as string, but based on the entity definition and usage in the codebase, it should be typed as QueryOrderingEnum | null. The entity uses QueryOrderingEnum (which has values 'ASC' or 'DESC'), and the data structure also defines it as optional. Consider updating the type to ensure type safety and consistency with the rest of the codebase.
No description provided.