fix(pegboard): restore hibernating request ids

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(pegboard): restore hibernating request ids #4898 : 3 dependent PRs (#4899 , #4916 , #4917 ) 👈 (View in Graphite)
• chore(guard): configure local timeout knobs #4913
• docs(rivetkit): raise serverless start payload limit #4911
• test(kitchen-sink): add sqlite memory soak harness #4910
• feat(rivetkit): expose runtime diagnostics #4909
• chore(depot-client): migrate to worker thread #4907 : 2 other dependent PRs (#4912 , #4918 )
• test(driver): select matrix cells with vitest filters #4906
• fix(pegboard): restore hibernating requests on serverful start #4904 : 1 other dependent PR (#4905 )
• fix(rivetkit): drain shutdown work before sleep #4902 : 1 other dependent PR (#4903 )
• feat(sqlite): wire remote sqlite execute handlers #4897
• test(serverless): avoid pinning header validation order #4896
• chore(driver-test-runner): add native/wasm runtime matrix to skill #4884 : 3 other dependent PRs (#4892 , #4894 , #4901 )
• chroe: rename rivetkit-sqlite to depot-client #4883
• fix(rivetkit-wasm): fix mem leaks #4880
• chore(rivetkit): wasm support #4860
• feat(sqlite): add cold read benchmarks and simplify optimizations #4857
• feat(sqlite): benchmark cold reads #4848 : 1 other dependent PR (#4864 )
• docs(actors): document manual lifecycle controls #4847
• test(sqlite): expand db stress coverage #4846 : 1 other dependent PR (#4849 )
• test(raw-websocket): add serverless smoke coverage #4845
• feat(serverless): configure drain grace period #4844
• fix(publish): enable frontend build for engine target and use turbo build instead of turbo build:engine #4843
• feat(rivetkit): expose conn handle in onWebSocket context #4842
• fix(rivetkit): normalize waitUntil/keepAwake promises to null to avoid serde undefined error #4841
• fix(rivetkit): remove requirement for token #4839 : 1 other dependent PR (#4840 )
• fix(pegboard-envoy): allow sqlite requests across lifecycle states #4838
• fix(pegboard): route scoped actor key reads by runner dc #4837
• fix(sqlite-storage): let sqlite open take over stale owners #4834
• fix(engine-tests): parallelize multi-DC startup + enable 6 multi-DC tests #4833
• fix(api): honor cursor in actor_ids list path #4832
• fix(api): silently filter invalid IDs from actor_ids query instead of 400 #4831
• fix(api-peer): make actors_delete idempotent for already-destroyed actors #4830
• fix(pegboard): use Iterator streaming mode in list_names so limit param is honored #4829
• chore(engine-tests): convert envoy tests to Sleep crash policy + triage ignored #4828
• feat(engine-tests): wire envoy actor names through prepopulate_actor_names #4827
• chore(depot): fault injection tests #4868
• feat(sqlite): pitr & forking #4859 : 1 other dependent PR (#4863 )
• chore(sqlite): stateless storage refactor #4856
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: fix(pegboard): restore hibernating request ids

Overview

This PR adds a regression test -- wake_start_clears_previous_sleep_request -- to verify that when an actor wakes from hibernation (LifecycleCommand::Start after handle_stop(ShutdownKind::Sleep)), the sleep_requested flag is properly cleared. The test guards against an actor immediately re-entering sleep on the next sleep-timer evaluation after waking.

Base branch: sqlite-soak/configure-guard-timeouts (not main). The production fix appears to live there (transition_to(LifecycleState::Started) calls ctx.clear_sleep_requested()); this PR contributes only the test.

---

Observations

Test structure and patterns are consistent. The actor factory, task wiring, and oneshot reply pattern all match established conventions in the file. The _ => {} wildcard arm on ActorEvent is flagged as a violation by CLAUDE.md, but it appears throughout this same test file (lines 108, 302, 350, 428, 881, 1043...), so this follows existing practice. If the project decides to enforce exhaustive matching in tests, this file needs a broader sweep, not a single-PR fix.

PR title vs. test name mismatch. The PR is titled "restore hibernating request ids" but the test is named wake_start_clears_previous_sleep_request and exercises only the boolean flag, not actual hibernating WebSocket connection restoration. It would help to either (a) align the PR title with what the test covers, or (b) add a companion test asserting restore_hibernating_requests is invoked with the correct HibernatingWebSocketMetadata entries when real connections are hibernated before sleep. The existing wake_start_hibernated_does_not_refire_connection_open covers reconnect suppression but not flag-clearing on wake.

Missing: the actual fix diff. The diff is test-only (70 additions, 0 deletions). If clear_sleep_requested() in transition_to() is the fix, a brief note in the PR description confirming it landed in the base branch would help reviewers understand the full change.

sleep_grace_period value. The test sets sleep_grace_period: Duration::from_millis(200) with sleep_grace_period_overridden: true. This is consistent with neighbouring tests but 200 ms could be flaky under CI load.

---

Verdict

The test is correct, readable, and guards a real edge case. Two actionable items:

1. Align the PR title with what the test actually exercises, or add a second test verifying hibernating request IDs are re-registered with the engine after wake.
2. Clarify in the PR description whether the production fix (clear_sleep_requested in transition_to) is in the base branch or added here -- the diff alone is ambiguous.

[NathanFlurry]

Landed in main via stack-merge fast-forward push. Commits are in main; closing to match.