fix(rivetkit): make duplicate sleep requests idempotent

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

• fix(pegboard): align drain grace defaults with stop threshold #4958 : 2 dependent PRs (#4960 , #4966 )
• fix(rivetkit): preserve bridge error messages #4959
• fix(rivetkit): fire abort signal on shutdown finalize #4957
• fix(rivetkit): use startup kv preload #4956
• fix(client): flatten skipReadyWait option #4955
• ci(publish): add manual preview publish flow #4954
• fix(depot): add ltx decode diagnostics #4953
• fix(universaldb): preserve plain set values #4952
• fix(universaldb): align versionstamp operand encoding #4951
• fix(rivetkit): export database provider types #4950
• wip: kitchen sink agentic loop finish #4949
• chore(rivetkit): note duplicate admission logic #4948
• test(rivetkit): cover bypass fetch header forwarding #4947
• feat(kitchen-sink): add actor probe controls #4946
• fix(gateway): split actor response wait errors #4945
• fix(guard): handle bypass preflight before query parse #4944
• feat(kitchen-sink): add mock agent event log copy #4943
• fix(kitchen-sink): default mock agent to local endpoint #4942
• test(rivetkit): enable driver lifecycle regressions #4941
• test(rivetkit): verify cached websocket db refs exceed grace #4940
• fix(rivetkit-core): keep sleeping actors reachable during grace #4939
• test(rivetkit): cover async websocket close db access #4938
• fix(rivetkit): keep actors awake until keepAwake work finishes #4937
• fix(rivetkit): persist native onSleep state on errors #4936
• fix(rivetkit-core): allow dispatch during sleep grace #4935
• fix(rivetkit): make duplicate sleep requests idempotent #4934 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review: fix(rivetkit): make duplicate sleep requests idempotent

Overview

This PR makes duplicate ctx.sleep() calls idempotent by returning Ok(()) instead of Err(ActorLifecycleError::Stopping) when sleep_requested was already set. It also re-enables a previously skipped test and improves its design to avoid the race conditions inherent in the original test structure.

---

Core Rust Change

Correct and minimal. The sleep_requested.swap(true, Ordering::SeqCst) returning true correctly signals a duplicate call. Returning Ok(()) here is semantically sound -- the actor will sleep as requested, the second call is just redundant.

Asymmetry with destroy() warrants a note. destroy() still returns Err(ActorLifecycleError::Stopping) on duplicate calls (lines 447-448 of context.rs). This asymmetry may be intentional (destroy is a stronger, escalating signal and is explicitly allowed after sleep), but it is worth confirming and documenting. The CLAUDE.md invariant in rivetkit-rust/packages/rivetkit-core/CLAUDE.md now needs updating -- the current bullet reads:

ctx.sleep() and ctx.destroy() return Result<()>. They error with ActorLifecycleError::Starting when called before startup completes and ActorLifecycleError::Stopping if the requested flag has already been set this generation.

After this change, sleep() no longer errors on duplicate -- only destroy() does. The bullet should be split to reflect the different behaviors.

---

Test Change

The test redesign is the right call. The original skipped test called triggerSleep twice sequentially via a connection, which had an inherent race: the second action could arrive after the actor had already started its shutdown sequence, requiring a try/catch workaround. The new triggerSleepTwice action calls sleep() twice within a single synchronous action invocation, directly testing the idempotency path in core without timing sensitivity.

Comments are clear and accurate. The new inline comment correctly explains why triggerSleepTwice is used over two separate calls.

Test assertions look correct. Expecting sleepCount === 1 and startCount === 2 after one double-sleep cycle correctly verifies that only one sleep occurred and the actor woke back up exactly once.

---

Minor Notes

• triggerSleepTwice is defined consistently across all three actor variants in sleep-db.ts (lines 49, 200, 277).
• Neither c.sleep() call has its return value checked in the fixture -- this is fine since the TypeScript c.sleep() is synchronous/void and after this fix neither call will throw for a started actor.
• No new test covers calling sleep() after the actor has already begun the grace period (lifecycle_started == false but sleep_requested == true). That path still correctly returns Err("actor is already shutting down"), but coverage for that boundary would be a nice follow-up.

---

Summary

The change is correct, well-scoped, and the test redesign is a meaningful improvement over the original flaky structure. One actionable item before merge:

1. Update the sleep invariant bullet in rivetkit-rust/packages/rivetkit-core/CLAUDE.md to reflect that sleep() is now idempotent on duplicate calls, while destroy() still errors.

[github-actions]

Preview packages published to npm

Install with:

npm install rivetkit@pr-4934

All packages published as 0.0.0-pr.4934.a2001b4 with tag pr-4934.

Engine binary is shipped via @rivetkit/engine-cli on linux-x64-musl, linux-arm64-musl, darwin-x64, and darwin-arm64. Windows users should use the release installer or set RIVET_ENGINE_BINARY.

Docker images:

docker pull rivetdev/engine:slim-a2001b4
docker pull rivetdev/engine:full-a2001b4

Individual packages

npm install rivetkit@pr-4934
npm install @rivetkit/react@pr-4934
npm install @rivetkit/rivetkit-napi@pr-4934
npm install @rivetkit/workflow-engine@pr-4934