fix(frontend): remove flashing upgrade notice#4451
fix(frontend): remove flashing upgrade notice#4451jog1t wants to merge 1 commit into03-17-fix_frotnend_fix_icons_kiling_the_bundlefrom
Conversation
|
🚅 Deployed to the rivet-pr-4451 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Code Review. PR: fix(frontend): remove flashing upgrade notice. File: frontend/src/components/actors/guard-connectable-inspector.tsx. Summary: Minimal, focused fix that corrects a subtle UX bug in the InspectorGuard component. Reorders two conditional checks to prevent an unintended flash of the upgrade notice during the initial query loading phase. Analysis - Root cause: The original guard evaluated the not-data/error/not-isInspectorAvailable check before the isLoading check. On first render, data is undefined while the query is in-flight, so the first branch fires immediately showing the upgrade banner before the query completes -- even for fully supported actors. The fix: Correct order after the patch checks isPending first (show ConnectingInspector during the initial fetch), then checks !data/error/!isInspectorAvailable (show OutdatedInspector only after the query settles). isLoading to isPending change: Semantically correct for TanStack Query v5. isLoading is isFetching && isPending, which can be false during a background refetch on stale data. isPending is true only when no cached data exists yet. Verdict: The fix is correct, minimal, and well-scoped. No concerns with code quality, security, or performance. |
2bd364e to
e83b68b
Compare
e88f43f to
9400b6d
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: