Skip to content

fix(frontend): remove flashing upgrade notice#4451

Draft
jog1t wants to merge 1 commit into03-17-fix_frotnend_fix_icons_kiling_the_bundlefrom
03-18-fix_frontend_remove_flashing_upgrade_notice
Draft

fix(frontend): remove flashing upgrade notice#4451
jog1t wants to merge 1 commit into03-17-fix_frotnend_fix_icons_kiling_the_bundlefrom
03-18-fix_frontend_remove_flashing_upgrade_notice

Conversation

@jog1t
Copy link
Contributor

@jog1t jog1t commented Mar 17, 2026

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link

railway-app bot commented Mar 17, 2026

🚅 Deployed to the rivet-pr-4451 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-cloud 😴 Sleeping (View Logs) Web Mar 19, 2026 at 9:06 am
frontend-inspector 😴 Sleeping (View Logs) Web Mar 18, 2026 at 9:31 pm
ladle ❌ Build Failed (View Logs) Web Mar 18, 2026 at 9:22 pm
website ❌ Build Failed (View Logs) Web Mar 17, 2026 at 11:11 pm
mcp-hub ✅ Success (View Logs) Web Mar 17, 2026 at 11:09 pm

Copy link
Contributor Author

jog1t commented Mar 17, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Mar 17, 2026

Code Review. PR: fix(frontend): remove flashing upgrade notice. File: frontend/src/components/actors/guard-connectable-inspector.tsx. Summary: Minimal, focused fix that corrects a subtle UX bug in the InspectorGuard component. Reorders two conditional checks to prevent an unintended flash of the upgrade notice during the initial query loading phase. Analysis - Root cause: The original guard evaluated the not-data/error/not-isInspectorAvailable check before the isLoading check. On first render, data is undefined while the query is in-flight, so the first branch fires immediately showing the upgrade banner before the query completes -- even for fully supported actors. The fix: Correct order after the patch checks isPending first (show ConnectingInspector during the initial fetch), then checks !data/error/!isInspectorAvailable (show OutdatedInspector only after the query settles). isLoading to isPending change: Semantically correct for TanStack Query v5. isLoading is isFetching && isPending, which can be false during a background refetch on stale data. isPending is true only when no cached data exists yet. Verdict: The fix is correct, minimal, and well-scoped. No concerns with code quality, security, or performance.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 17, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4451

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4451

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4451

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4451

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4451

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4451

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4451

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4451

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4451

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4451

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4451

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4451

commit: e83b68b

@jog1t jog1t force-pushed the 03-18-fix_frontend_remove_flashing_upgrade_notice branch from 2bd364e to e83b68b Compare March 18, 2026 21:19
@jog1t jog1t force-pushed the 03-17-fix_frotnend_fix_icons_kiling_the_bundle branch from e88f43f to 9400b6d Compare March 18, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant