Skip to content

fix(engine): use proper paths for settings#4447

Open
jog1t wants to merge 1 commit into03-17-feat_frontend_add_outdated_indicator_to_runnersfrom
03-17-fix_engine_use_proper_paths_for_settings
Open

fix(engine): use proper paths for settings#4447
jog1t wants to merge 1 commit into03-17-feat_frontend_add_outdated_indicator_to_runnersfrom
03-17-fix_engine_use_proper_paths_for_settings

Conversation

@jog1t
Copy link
Contributor

@jog1t jog1t commented Mar 17, 2026

Description

This change renames the engine route from /connect to /settings and enhances the sidebar navigation with improved visual design. The main changes include:

  • Renamed connect.tsx to settings.tsx and updated the route path from /ns/$namespace/connect to /ns/$namespace/settings
  • Added start icons to sidebar header buttons (gift icon for changelog, message icon for feedback, book icon for docs, Discord and GitHub icons for community links)
  • Renamed Subnav component to EngineSubnav and restructured its layout to include a Settings link and improved spacing
  • Changed the "Instances" label to "Actors" in the navigation
  • Updated button variants in the actors list empty state from outline/secondary to ghost
  • Simplified the provider dropdown in settings by removing the submenu structure for non-cloud app types

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor Author

jog1t commented Mar 17, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@railway-app
Copy link

railway-app bot commented Mar 17, 2026

🚅 Deployed to the rivet-pr-4447 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-cloud 😴 Sleeping (View Logs) Web Mar 17, 2026 at 9:26 pm
frontend-inspector 😴 Sleeping (View Logs) Web Mar 17, 2026 at 9:24 pm
website ❌ Build Failed (View Logs) Web Mar 17, 2026 at 9:17 pm
ladle ❌ Build Failed (View Logs) Web Mar 17, 2026 at 9:17 pm
mcp-hub ✅ Success (View Logs) Web Mar 17, 2026 at 9:16 pm

@jog1t jog1t marked this pull request as ready for review March 17, 2026 21:16
@claude
Copy link

claude bot commented Mar 17, 2026

PR Review

Summary

This PR fixes frontend routing by renaming the engine settings route from /connect to /settings, which better reflects the page purpose. It also includes related UI polish.

What's Good

  • The route rename from connect to settings is a meaningful correction. The old path /ns/$namespace/connect was misleading for a settings page.
  • routeTree.gen.ts changes are expected auto-generated output from the route rename.
  • EngineSubnav is a clearer name than Subnav.
  • The 'Go to Settings' link fix in actors-list.tsx correctly targets /settings now.

Issues / Feedback

1. PR description is empty
The PR template checkboxes are all unchecked and no description was provided. Please fill in what changed and why, especially since there are both a bug fix and UI changes bundled together.

2. Scope relative to PR title
The commit title is fix(engine): use proper paths for settings but the diff also includes icon additions to sidebar header buttons (faBook, faDiscord, faGithub), button variant changes (outline/secondary to ghost), gap and border tweaks in EngineSubnav, and engine-specific ProviderDropdown behavior in settings.tsx. These are reasonable changes but should be called out in the description so reviewers understand the intent.

3. Engine-mode ProviderDropdown behavior worth confirming
In settings.tsx, engine mode now renders external cloud items flat (no submenu, no Rivet Cloud option) while cloud mode wraps them in a submenu. This UX difference seems intentional but is not documented anywhere. A short note in the PR description confirming this is the desired behavior would help reviewers.

4. Draft status and downstack dependency
This is still a draft and depends on PR #4446. No action needed until that is resolved.


No security or performance concerns. Overall this is a straightforward fix — main ask is to fill out the PR description and confirm the ProviderDropdown engine-mode behavior is intentional.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 17, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4447

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4447

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4447

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4447

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4447

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4447

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4447

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4447

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4447

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4447

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4447

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4447

commit: 4170ed2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant