fix(api): dont 500 on cross dc response#4449
Open
MasterPtato wants to merge 1 commit into03-17-chore_update_byte_units_on_frontendfrom
Open
fix(api): dont 500 on cross dc response#4449MasterPtato wants to merge 1 commit into03-17-chore_update_byte_units_on_frontendfrom
MasterPtato wants to merge 1 commit into03-17-chore_update_byte_units_on_frontendfrom
Conversation
|
🚅 Deployed to the rivet-pr-4449 environment in rivet-frontend
|
11 tasks
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
|
PR Review: fix(api): dont 500 on cross dc response. The reqwest_to_axum_response function previously used anyhow::bail!() on non-2xx remote DC responses, causing 500s to be returned to clients. The fix correctly logs the error and falls through to forward the actual status code. Structured logging follows CLAUDE.md conventions. Fix is correct and minimal. |
29a5224 to
8ee527a
Compare
d4011f0 to
3b845cb
Compare
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes RVT-6105
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: