Skip to content

fix(api): dont 500 on cross dc response#4449

Open
MasterPtato wants to merge 1 commit into03-17-chore_update_byte_units_on_frontendfrom
03-17-fix_api_dont_500_on_cross_dc_response
Open

fix(api): dont 500 on cross dc response#4449
MasterPtato wants to merge 1 commit into03-17-chore_update_byte_units_on_frontendfrom
03-17-fix_api_dont_500_on_cross_dc_response

Conversation

@MasterPtato
Copy link
Contributor

@MasterPtato MasterPtato commented Mar 17, 2026

Fixes RVT-6105

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link

railway-app bot commented Mar 17, 2026

🚅 Deployed to the rivet-pr-4449 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-cloud 😴 Sleeping (View Logs) Web Mar 17, 2026 at 10:52 pm
frontend-inspector 😴 Sleeping (View Logs) Web Mar 17, 2026 at 10:50 pm
website ❌ Build Failed (View Logs) Web Mar 17, 2026 at 10:41 pm
mcp-hub ✅ Success (View Logs) Web Mar 17, 2026 at 10:40 pm
ladle ❌ Build Failed (View Logs) Web Mar 17, 2026 at 10:39 pm

Copy link
Contributor Author

MasterPtato commented Mar 17, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Mar 17, 2026

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 17, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4449

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4449

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4449

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4449

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4449

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4449

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4449

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4449

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4449

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4449

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4449

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4449

commit: 8ee527a

@claude
Copy link

claude bot commented Mar 17, 2026

PR Review: fix(api): dont 500 on cross dc response. The reqwest_to_axum_response function previously used anyhow::bail!() on non-2xx remote DC responses, causing 500s to be returned to clients. The fix correctly logs the error and falls through to forward the actual status code. Structured logging follows CLAUDE.md conventions. Fix is correct and minimal.

@MasterPtato MasterPtato force-pushed the 03-17-fix_api_dont_500_on_cross_dc_response branch from 29a5224 to 8ee527a Compare March 18, 2026 22:12
@MasterPtato MasterPtato force-pushed the 03-17-chore_update_byte_units_on_frontend branch from d4011f0 to 3b845cb Compare March 18, 2026 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant