chore: update byte units on frontend#4444
Open
MasterPtato wants to merge 1 commit into03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_getfrom
Open
chore: update byte units on frontend#4444MasterPtato wants to merge 1 commit into03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_getfrom
MasterPtato wants to merge 1 commit into03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_getfrom
Conversation
|
🚅 Deployed to the rivet-pr-4444 environment in rivet-frontend
|
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
PR Review: chore: update byte units on frontend\n\nThis is a correct and well-scoped fix. The underlying code was already using binary (base-2) math via bigBytes.GiB(), bigBytes.TiB(), bytes.KiB(), etc., but display labels and comments used SI decimal prefixes (KB, MB, GB, TB). This PR aligns the labels with the actual binary semantics.\n\n### Summary of changes\n\n| File | Change type |\n|------|-------------|\n| billing-page.tsx | Label-only: 4KB to 4KiB in descriptions |\n| plan-card.tsx | Label-only: GB/TB to GiB/TiB in plan feature lists |\n| usage-card.tsx | Functional: divisors corrected from 1000-based to 1024-based, plus unit labels updated |\n| metrics/constants.ts | Comment-only: 4KB to 4KiB |\n| billing.ts | Comment-only: GB/TB to GiB/TiB throughout |\n\n### Looks good\n\n- The only file with a meaningful logic change is usage-card.tsx. Previously it divided byte values by 1000-based multipliers (e.g., GB = 1000 * 1000 * 1000) while displaying a 'GB' label. Since stored values are binary, both the divisors and labels are now correctly fixed to IEC units.\n- All other files are comment/label corrections. Numeric values in billing.ts (e.g., bigBytes.GiB(100n)) were already correct and unchanged.\n- The inline comments on BILLING.included (e.g., // 100 GiB) now accurately describe what bigBytes.GiB(100n) produces.\n\n### Minor notes\n\nInconsistency in usage-card.tsx operations case: The bytes case now uses named constants (KiB, MiB, etc.), but the operations case still uses the raw literal 4096. Not a bug, but worth making consistent with the named-constant style used elsewhere in the same file.\n\nDocs check: CLAUDE.md asks to update website/src/content/docs/actors/limits.mdx when limits or unit terminology changes. The existing limits doc already uses GiB notation for KV storage, so no update is needed here, but worth a quick scan to confirm plan-tier descriptions are consistent if they appear anywhere in the docs. |
MasterPtato
force-pushed
the
03-17-chore_update_byte_units_on_frontend
branch
from
f1b6d0a to
d4011f0
Compare
MasterPtato
force-pushed
the
03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_get
branch
from
5b2bead to
cfc4fad
Compare
railway-app
bot
temporarily deployed
to
rivet-frontend / rivet-pr-4444
11 tasks
MasterPtato
force-pushed
the
03-17-chore_update_byte_units_on_frontend
branch
from
d4011f0 to
3b845cb
Compare
MasterPtato
force-pushed
the
03-17-fix_runner_alloc_idx_logic_api_auth_for_actor_get
branch
from
cfc4fad to
65280b5
Compare
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: