-
Notifications
You must be signed in to change notification settings - Fork 146
fix(dashboard): use proper timestamp for actor status #3809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
More templates
@rivetkit/cloudflare-workers
@rivetkit/db
@rivetkit/framework-base
@rivetkit/next-js
@rivetkit/react
rivetkit
@rivetkit/sql-loader
@rivetkit/virtual-websocket
@rivetkit/engine-runner
@rivetkit/engine-runner-protocol
commit: |
Graphite Automations"Test" took an action on this PR • (01/10/26)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
Code Review - PR #3809: fix(dashboard): use proper timestamp for actor statusSummaryThis PR updates the actor status determination logic to use ✅ Positive Findings
🔍 Issues & ConcernsCRITICAL: Potential Bug in
|
40c61b5 to
6685854
Compare
02177f1 to
6d330ea
Compare
6d330ea to
7cc0b04
Compare
6685854 to
6a5422f
Compare
6a5422f to
658a057
Compare
658a057 to
10592fc
Compare
14a854f to
9814eb6
Compare
10592fc to
3a4638c
Compare
3a4638c to
10592fc
Compare
10592fc to
9d865a4
Compare
9814eb6 to
96eb8ac
Compare
96eb8ac to
d16e118
Compare
9d865a4 to
1848d64
Compare
d16e118 to
96eb8ac
Compare
1848d64 to
9d865a4
Compare
96eb8ac to
d16e118
Compare
9d865a4 to
1848d64
Compare
Merge activity
|
### TL;DR Updated actor status determination to use `connectableAt` instead of `startedAt` timestamp. ### What changed? - Added `connectableAt` field to the actor transformation in `inspector-data-provider.tsx` - Modified the `getActorStatus` function to use `connectableAt` instead of `startedAt` when determining actor status - Updated the function parameter type to include the new `connectableAt` field ### How to test? 1. Verify actor status is correctly displayed in the UI for actors in different states 2. Check that actors show the correct status transitions (starting → running → stopped/crashed) 3. Confirm that pending and sleeping states are still properly detected ### Why make this change? The `connectableAt` timestamp provides a more accurate indicator of when an actor becomes available for connections, making it a better signal for determining the actor's running state than the previously used `startedAt` field. This change improves the accuracy of actor status reporting in the UI.

TL;DR
Updated actor status determination to use
connectableAtinstead ofstartedAttimestamp.What changed?
connectableAtfield to the actor transformation ininspector-data-provider.tsxgetActorStatusfunction to useconnectableAtinstead ofstartedAtwhen determining actor statusconnectableAtfieldHow to test?
Why make this change?
The
connectableAttimestamp provides a more accurate indicator of when an actor becomes available for connections, making it a better signal for determining the actor's running state than the previously usedstartedAtfield. This change improves the accuracy of actor status reporting in the UI.