Skip to content

Demote error/panic logging to info (from warn or error) #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandur merged 1 commit into from
Apr 1, 2026
+7 −4
Merged

Demote error/panic logging to info (from warn or error) #1190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Jobs erroring or panicking no longer logs at the error/warn level because this is not indicative of a problem inside of River itself. These log statements have been demoted to info. [PR #1190](https://github.com/riverqueue/river/pull/1190).

### Fixed

- Fix in `Client.Start` where previously it was possible for a River client that only partially started before erroring to not try to start on subsequent `Start` invocations. [PR #1187](https://github.com/riverqueue/river/pull/1187).
Expand Down
1 change: 0 additions & 1 deletion example_graceful_shutdown_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,5 +168,4 @@ func Example_gracefulShutdown() {
// Received SIGINT/SIGTERM; initiating soft stop (try to wait for jobs to finish)
// Received SIGINT/SIGTERM again; initiating hard stop (cancel everything)
// Job cancelled
// msg="jobexecutor.JobExecutor: Job errored; retrying" error="context canceled" job_kind=waits_for_cancel_only
}
6 changes: 3 additions & 3 deletions internal/jobexecutor/job_executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,12 +436,12 @@ func (e *JobExecutor) reportError(ctx context.Context, jobRow *rivertype.JobRow,
e.Logger.DebugContext(ctx, e.Name+": Job cancelled explicitly", logAttrs...)
case res.Err != nil:
if jobRow.Attempt >= jobRow.MaxAttempts {
e.Logger.ErrorContext(ctx, e.Name+": Job errored", logAttrs...)
e.Logger.InfoContext(ctx, e.Name+": Job errored", logAttrs...)
} else {
e.Logger.WarnContext(ctx, e.Name+": Job errored; retrying", logAttrs...)
e.Logger.InfoContext(ctx, e.Name+": Job errored; retrying", logAttrs...)
}
case res.PanicVal != nil:
e.Logger.ErrorContext(ctx, e.Name+": Job panicked", logAttrs...)
e.Logger.InfoContext(ctx, e.Name+": Job panicked", logAttrs...)
}

if e.ErrorHandler != nil && !cancelJob {
Expand Down
Loading