Demote error/panic logging to info (from warn or error)#1190
Merged
Conversation
brandur
force-pushed
the
brandur-downgrade-to-info
branch
from
c6a69dd to
571609f
Compare
brandur
force-pushed
the
brandur-downgrade-to-info
branch
from
571609f to
12f7500
Compare
bgentry
approved these changes
Apr 1, 2026
Related to #1189. Currently, when a job errors or panics, River will either error or warn (if there will be more retries). There's a strong case that this current behavior is wrong because although a job erroring/panicking is bad, it's not indicative of an actual problem inside of River itself. Instead, users should rely on the normal job error/panic introspection mechanisms like the errors stored to the job row itself, a client error handler, custom hook, or their own logging. Here, demote the error/warn logs to info. Fixes #1189.
brandur
force-pushed
the
brandur-downgrade-to-info
branch
from
12f7500 to
302a095
Compare
Contributor
Author
|
thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1189. Currently, when a job errors or panics, River will
either error or warn (if there will be more retries).
There's a strong case that this current behavior is wrong because
although a job erroring/panicking is bad, it's not indicative of an
actual problem inside of River itself. Instead, users should rely on the
normal job error/panic introspection mechanisms like the errors stored
to the job row itself, a client error handler, custom hook, or their own
logging.
Here, demote the error/warn logs to info.
Fixes #1189.