Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"@testing-library/user-event": "^14.6.1",
"@types/node": "^20.11.0",
"@types/react": "^18.2.0",
"@types/react-dom": "^18.2.0",
"@types/react-dom": "^19.2.3",
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Major version mismatch: @types/react-dom is bumped to v19 while react-dom, react, and @types/react are all on v18. The v19 type definitions expect React 19 APIs and have a peer dependency on @types/react@^19. This will likely cause type errors during pnpm lint (tsc --noEmit) and may break the build. Either upgrade the entire React stack to v19, or keep @types/react-dom on v18 to match the rest of the project.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 56:

<comment>Major version mismatch: `@types/react-dom` is bumped to v19 while `react-dom`, `react`, and `@types/react` are all on v18. The v19 type definitions expect React 19 APIs and have a peer dependency on `@types/react@^19`. This will likely cause type errors during `pnpm lint` (`tsc --noEmit`) and may break the build. Either upgrade the entire React stack to v19, or keep `@types/react-dom` on v18 to match the rest of the project.</comment>

<file context>
@@ -53,7 +53,7 @@
     "@types/node": "^20.11.0",
     "@types/react": "^18.2.0",
-    "@types/react-dom": "^18.2.0",
+    "@types/react-dom": "^19.2.3",
     "@types/react-window": "^2.0.0",
     "@types/uuid": "^11.0.0",
</file context>
Suggested change
"@types/react-dom": "^19.2.3",
"@types/react-dom": "^18.2.0",
Fix with Cubic

"@types/react-window": "^2.0.0",
"@types/uuid": "^11.0.0",
"autoprefixer": "^10.4.18",
Expand Down
Loading