chore(deps-dev): bump @types/react-dom from 18.3.7 to 19.2.3#17
Open
dependabot[bot] wants to merge 1 commit intomainfrom
Open
chore(deps-dev): bump @types/react-dom from 18.3.7 to 19.2.3#17dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="package.json">
<violation number="1" location="package.json:56">
P1: Major version mismatch: `@types/react-dom` is bumped to v19 while `react-dom`, `react`, and `@types/react` are all on v18. The v19 type definitions expect React 19 APIs and have a peer dependency on `@types/react@^19`. This will likely cause type errors during `pnpm lint` (`tsc --noEmit`) and may break the build. Either upgrade the entire React stack to v19, or keep `@types/react-dom` on v18 to match the rest of the project.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "@types/node": "^20.11.0", | ||
| "@types/react": "^18.2.0", | ||
| "@types/react-dom": "^18.2.0", | ||
| "@types/react-dom": "^19.2.3", |
There was a problem hiding this comment.
P1: Major version mismatch: @types/react-dom is bumped to v19 while react-dom, react, and @types/react are all on v18. The v19 type definitions expect React 19 APIs and have a peer dependency on @types/react@^19. This will likely cause type errors during pnpm lint (tsc --noEmit) and may break the build. Either upgrade the entire React stack to v19, or keep @types/react-dom on v18 to match the rest of the project.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At package.json, line 56:
<comment>Major version mismatch: `@types/react-dom` is bumped to v19 while `react-dom`, `react`, and `@types/react` are all on v18. The v19 type definitions expect React 19 APIs and have a peer dependency on `@types/react@^19`. This will likely cause type errors during `pnpm lint` (`tsc --noEmit`) and may break the build. Either upgrade the entire React stack to v19, or keep `@types/react-dom` on v18 to match the rest of the project.</comment>
<file context>
@@ -53,7 +53,7 @@
"@types/node": "^20.11.0",
"@types/react": "^18.2.0",
- "@types/react-dom": "^18.2.0",
+ "@types/react-dom": "^19.2.3",
"@types/react-window": "^2.0.0",
"@types/uuid": "^11.0.0",
</file context>
Suggested change
| "@types/react-dom": "^19.2.3", | |
| "@types/react-dom": "^18.2.0", |
Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 18.3.7 to 19.2.3. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) --- updated-dependencies: - dependency-name: "@types/react-dom" dependency-version: 19.2.3 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7ec2c2b to
e8b35be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @types/react-dom from 18.3.7 to 19.2.3.
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Summary by cubic
Bump
@types/react-domfrom 18.3.7 to 19.2.3 to align with React 19 DOM typings and improve type checks. Dev-only; no runtime impact.Written for commit e8b35be. Summary will update on new commits.