Issue 39: Reduce code duplication #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #39 by reducing code duplication for selector components. Key changes include the extraction of common selector utility functions into SelectorUtils.tsx, updating Select.tsx and MultiSelect.tsx to use these new utilities, and replacing plain text icons with SVGs in SelectionList.tsx.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/SelectorUtils.tsx | Introduces shared utility functions for measuring component dimensions and rendering arrows. |
| src/components/SelectionList.tsx | Replaces text clear icon with an SVG version for better styling consistency. |
| src/components/Select.tsx | Refactors inline functions to use the new shared utilities from SelectorUtils.tsx. |
| src/components/MultiSelect.tsx | Similar refactor as in Select.tsx, leveraging the shared utilities. |
| package.json | Adds react-native-svg as a dependency. |
| example/package.json | Updates dependency configuration to reference react-native-svg correctly. |
Files not reviewed (1)
- example/package-lock.json: Language not supported
Collaborator
|
@ian-zyh please merge |
fulformc
requested changes
Nov 29, 2025
… add refRectYOffset to replace hardcode
fulformc
requested changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aimed to solve issue #39
Added a file named "SelectorUtils.tsx" under folder "utils", all the repeated methods of Select.tsx and MultiSelect.tsx were moved here.
(This branch is merged from rhit-zhuy17/113-change-dropdown-icons-format, so the icons are already in svg format.)