Skip to content

Add KUBECTL_WAIT_TIMEOUT for controlling integration and helmchart-test targets #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sabre1041 merged 2 commits into from
Apr 3, 2026
+15 −4
Merged

Add KUBECTL_WAIT_TIMEOUT for controlling integration and helmchart-test targets #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44fcea4
testing KUBECTL_WAIT_TIMEOUT
Apr 2, 2026
6a4ad7c
20m vault KUBECTL_WAIT_TIMEOUT
Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/pr-operator.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ on:
default: "${{ github.repository }}"
required: false
type: string
KUBECTL_WAIT_TIMEOUT:
description: "kubectl wait timeout used for integration and helmchart-test targets in the Makefile (e.g. 5m)"
default: "5m"
required: false
type: string
env:
DEFAULT_BUNDLE_VERSION: "0.0.1"
DEFAULT_BUNDLE_CHANNEL: "alpha"
Expand Down Expand Up @@ -569,7 +574,7 @@ jobs:
- name: Run integration tests
shell: bash
if: ${{ inputs.RUN_INTEGRATION_TESTS }}
run: make integration
run: make integration KUBECTL_WAIT_TIMEOUT=${{ inputs.KUBECTL_WAIT_TIMEOUT }}

test-helmchart:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -622,7 +627,7 @@ jobs:

- name: Test Helm Chart Deployment
shell: bash
run: make helmchart-test OPERATOR_NAME=${{ env.REPOSITORY_NAME }}
run: make helmchart-test OPERATOR_NAME=${{ env.REPOSITORY_NAME }} KUBECTL_WAIT_TIMEOUT=${{ inputs.KUBECTL_WAIT_TIMEOUT }}

recombine-dist:
runs-on: ubuntu-latest
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/release-operator.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ on:
default: false
required: false
type: boolean
KUBECTL_WAIT_TIMEOUT:
description: "kubectl wait timeout used for integration and helmchart-test targets in the Makefile (e.g. 5m)"
default: "5m"
required: false
type: string
secrets:
COMMUNITY_OPERATOR_PAT:
description: "Github PAT Token for Community Operator Fork Git Operations"
Expand Down Expand Up @@ -1103,7 +1108,7 @@ jobs:
- name: Run integration tests
shell: bash
if: ${{ inputs.RUN_INTEGRATION_TESTS }}
run: make integration
run: make integration KUBECTL_WAIT_TIMEOUT=${{ inputs.KUBECTL_WAIT_TIMEOUT }}

test-helmchart:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -1154,4 +1159,4 @@ jobs:

- name: Test Helm Chart Deployment
shell: bash
run: make helmchart-test
run: make helmchart-test KUBECTL_WAIT_TIMEOUT=${{ inputs.KUBECTL_WAIT_TIMEOUT }}
1 change: 1 addition & 0 deletions .github/workflows/test-vault-config-operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,4 @@ jobs:
GO_VERSION: ~1.22
OPERATOR_SDK_VERSION: v1.31.0
CHECKOUT_CODE: "redhat-cop/vault-config-operator"
KUBECTL_WAIT_TIMEOUT: 20m
Loading