[dead-code] Add RemoveConditionExactReturnRector

rules-tests/DeadCode/Rector/Stmt/RemoveDeadStmtRector/Fixture/binary_op.php.inc → rules-tests/DeadCode/Rector/Expression/RemoveDeadStmtRector/Fixture/binary_op.php.inc

@@ -64,7 +64,7 @@ function wrapToPreventPhpStanCallingMethods ()
 {
     foo();
     foo();
-    foo2();
     foo3();
+    foo2();
 }
 ?>

rules-tests/DeadCode/Rector/Stmt/RemoveDeadStmtRector/Fixture/class_constant_fetch.php.inc → rules-tests/DeadCode/Rector/Expression/RemoveDeadStmtRector/Fixture/class_constant_fetch.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods ()
 {
@@ -14,7 +14,7 @@ function wrapToPreventPhpStanCallingMethods ()
 -----
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods ()
 {

rules-tests/DeadCode/Rector/Stmt/RemoveDeadStmtRector/Fixture/clone.php.inc → rules-tests/DeadCode/Rector/Expression/RemoveDeadStmtRector/Fixture/clone.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods ($object)
 {
@@ -11,7 +11,7 @@ function wrapToPreventPhpStanCallingMethods ($object)
 -----
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods ($object)
 {

rules-tests/DeadCode/Rector/Stmt/RemoveDeadStmtRector/Fixture/closure.php.inc → rules-tests/DeadCode/Rector/Expression/RemoveDeadStmtRector/Fixture/closure.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods ()
 {
@@ -11,7 +11,7 @@ function wrapToPreventPhpStanCallingMethods ()
 -----
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods ()
 {

rules-tests/DeadCode/Rector/Stmt/RemoveDeadStmtRector/Fixture/instanceOf.php.inc → rules-tests/DeadCode/Rector/Expression/RemoveDeadStmtRector/Fixture/instanceOf.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods ()
 {
@@ -15,7 +15,7 @@ function wrapToPreventPhpStanCallingMethods ()
 -----
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods ()
 {

rules-tests/DeadCode/Rector/Stmt/RemoveDeadStmtRector/Fixture/isset.php.inc → rules-tests/DeadCode/Rector/Expression/RemoveDeadStmtRector/Fixture/isset.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods ($object)
 {
@@ -15,16 +15,16 @@ function wrapToPreventPhpStanCallingMethods ($object)
 -----
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods ($object)
 {
     $a = isset($a);
     $b = isset($b, $c, $d);
-
-    func1();
     func2();
     func3();
     func4();
+
+    func1();
 }
 ?>

rules-tests/DeadCode/Rector/Expression/RemoveDeadStmtRector/Fixture/static_property_fetch.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
+
+function wrapToPreventPhpStanCallingMethods ()
+{
+    $a = SomeClass::$a;
+
+    SomeClass::$a;
+
+    bar()::$a;
+
+    bar()::${baz()}::${foo()};
+}
+?>

rules-tests/DeadCode/Rector/Stmt/RemoveDeadStmtRector/Fixture/unairy.php.inc → rules-tests/DeadCode/Rector/Expression/RemoveDeadStmtRector/Fixture/unairy.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods ()
 {
@@ -18,7 +18,7 @@ function wrapToPreventPhpStanCallingMethods ()
 -----
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods ()
 {

rules-tests/DeadCode/Rector/Stmt/RemoveDeadStmtRector/Fixture/variable.php.inc → rules-tests/DeadCode/Rector/Expression/RemoveDeadStmtRector/Fixture/variable.php.inc

@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods()
 {
@@ -14,7 +14,7 @@ function wrapToPreventPhpStanCallingMethods()
 -----
 <?php
 
-namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveDeadStmtRector\Fixture;
+namespace Rector\Tests\DeadCode\Rector\Expression\RemoveDeadStmtRector\Fixture;
 
 function wrapToPreventPhpStanCallingMethods()
 {

rules-tests/DeadCode/Rector/Stmt/RemoveDeadStmtRector/FixtureRemovedComments/array_dim_fetch.php.inc → rules-tests/DeadCode/Rector/Expression/RemoveDeadStmtRector/FixtureRemovedComments/array_dim_fetch.php.inc

@@ -32,9 +32,10 @@ function wrapToPreventPhpStanCallingMethods ()
 
     //comment
     methodCall();
+    //comment
+    methodCall2();
 
     //comment
     methodCall1();
-    methodCall2();
 }
 ?>

rules-tests/DeadCode/Rector/Stmt/RemoveDeadStmtRector/FixtureRemovedComments/property_fetch.php.inc → rules-tests/DeadCode/Rector/Expression/RemoveDeadStmtRector/FixtureRemovedComments/property_fetch.php.inc

@@ -18,23 +18,3 @@ function wrapToPreventPhpStanCallingMethods ()
     ${methodCall1()}->{methodCall2()};
 }
 ?>
------
-<?php
-
-namespace Rector\Tests\CodeQuality\Rector\Stmt\DeadCodeRemovingRector\Fixture\PropertyFetch;
-
-function wrapToPreventPhpStanCallingMethods ()
-{
-    $var->prop = 1;
-
-    //comment
-    methodCall();
-
-    //comment
-    methodCall();
-
-    //comment
-    methodCall1();
-    methodCall2();
-}
-?>

rules-tests/DeadCode/Rector/Stmt/RemoveConditionExactReturnRector/Fixture/allow_any_type.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveConditionExactReturnRector\Fixture;
+
+final class AllowAnyType
+{
+    public function run($result)
+    {
+        if ($result === []) {
+            return [];
+        }
+
+        return $result;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveConditionExactReturnRector\Fixture;
+
+final class AllowAnyType
+{
+    public function run($result)
+    {
+        return $result;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Stmt/RemoveConditionExactReturnRector/Fixture/allow_equal.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveConditionExactReturnRector\Fixture;
+
+final class AllowEqual
+{
+    public function run(array $result)
+    {
+        if ($result == []) {
+            return [];
+        }
+
+        return $result;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveConditionExactReturnRector\Fixture;
+
+final class AllowEqual
+{
+    public function run(array $result)
+    {
+        return $result;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Stmt/RemoveConditionExactReturnRector/Fixture/any_expr_compare.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveConditionExactReturnRector\Fixture;
+
+final class AnyExprCompare
+{
+    public function run(array $result)
+    {
+        if ($result == 999) {
+            return 999;
+        }
+
+        return $result;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveConditionExactReturnRector\Fixture;
+
+final class AnyExprCompare
+{
+    public function run(array $result)
+    {
+        return $result;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Stmt/RemoveConditionExactReturnRector/Fixture/skip_different_return.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveConditionExactReturnRector\Fixture;
+
+final class SkipDifferentReturn
+{
+    public function run(array $result)
+    {
+        if ($result === []) {
+            return [];
+        }
+
+        return 500;
+    }
+}

rules-tests/DeadCode/Rector/Stmt/RemoveConditionExactReturnRector/Fixture/skip_side_effect_call.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveConditionExactReturnRector\Fixture;
+
+final class SkipSideEffectCall
+{
+    public function run($result)
+    {
+        if ($result === $this->isMissing(100)) {
+            return $this->isMissing(100);
+        }
+
+        return $result;
+    }
+
+    private function isMissing(int $int): int
+    {
+        return mt_rand(0, 1) * $int;
+    }
+}

rules-tests/DeadCode/Rector/Stmt/RemoveConditionExactReturnRector/Fixture/some_class.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveConditionExactReturnRector\Fixture;
+
+final class SomeClass
+{
+    public function run(array $result)
+    {
+        if ($result === []) {
+            return [];
+        }
+
+        return $result;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveConditionExactReturnRector\Fixture;
+
+final class SomeClass
+{
+    public function run(array $result)
+    {
+        return $result;
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/Stmt/RemoveConditionExactReturnRector/RemoveConditionExactReturnRectorTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\Stmt\RemoveConditionExactReturnRector;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class RemoveConditionExactReturnRectorTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

rules-tests/DeadCode/Rector/Stmt/RemoveConditionExactReturnRector/config/configured_rule.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\Stmt\RemoveConditionExactReturnRector;
+
+return RectorConfig::configure()
+    ->withRules([RemoveConditionExactReturnRector::class]);