[dead-code] Add RemoveConditionExactReturnRector #7482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
Member
Author
|
I've realized this can be extended for any compared value, WIP |
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-empty-value-or-type-return
branch
from
320cef7 to
98456f6
Compare
TomasVotruba
force-pushed
the
tv-empty-value-or-type-return
branch
from
b4aa078 to
7f19815
Compare
samsonasik
reviewed
Oct 12, 2025
Comment on lines
+98
to
+102
| if ($identicalOrEqual->right instanceof MethodCall) { | ||
| continue; | ||
| } | ||
|
|
||
| if ($identicalOrEqual->right instanceof StaticCall) { |
Member
There was a problem hiding this comment.
there is SideEffectNodeDetector service for it, I will create new PR for it.
Member
There was a problem hiding this comment.
samsonasik
reviewed
Oct 13, 2025
Comment on lines
+31
to
+57
| <<<'CODE_SAMPLE' | ||
| final class SomeClass | ||
| { | ||
| public function __construct(array $items) | ||
| { | ||
| if ($items === []) { | ||
| return []; | ||
| } | ||
|
|
||
| return $items; | ||
| } | ||
| } | ||
| CODE_SAMPLE | ||
|
|
||
| , | ||
| <<<'CODE_SAMPLE' | ||
| final class SomeClass | ||
| { | ||
| public function __construct(array $items) | ||
| { | ||
| if ($items === []) { | ||
| return []; | ||
| } | ||
|
|
||
| return $items; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
before vs after code sample is equal, detected at getrector.com website
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
We should have a CI check for this here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These structure are identical and can be narrowed:
It doesn't make sense to compare variable to X and then return X or X. Just return X directly :)