Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?php

namespace Rector\Tests\CodeQuality\Rector\BooleanOr\RepeatedOrEqualToInArrayRector\Fixture;

final class SkipMixEqualAndIdentical
{
public function demo()
{
$a = false;
var_dump($a == 'a' || $a == 'b' || $a === null);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,13 @@ public function refactor(Node $node): ?FuncCall
$identicals = $this->betterNodeFinder->findInstanceOf($node, Identical::class);
$equals = $this->betterNodeFinder->findInstanceOf($node, Equal::class);

if ($identicals !== [] && $equals === []) {
if ($identicals !== []) {
if ($equals !== []) {
// mix identical and equals, keep as is
// @see https://3v4l.org/24cFl
return null;
}

$args[] = new Arg(new ConstFetch(new Name('true')));
}

Expand Down