Skip to content

Conversation

@samsonasik
Copy link
Member

Given the following code:

$a = false;
var_dump($a == 'a' || $a == 'b' || $a === null);

It produce:

-        var_dump($a == 'a' || $a == 'b' || $a === null);
+        var_dump(in_array($a, ['a', 'b', null]));

which invalid on result, see https://3v4l.org/24cFl

@samsonasik
Copy link
Member Author

Fixed 🎉 /cc @TomasVotruba

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik enabled auto-merge (squash) October 3, 2025 05:23
@samsonasik samsonasik merged commit 155b0f3 into main Oct 3, 2025
50 checks passed
@samsonasik samsonasik deleted the skip-mix-equal-identical branch October 3, 2025 05:24
@TomasVotruba
Copy link
Member

I though this might a be an edge case. LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants