[CodeQuality] Fix escape character on SimplifyRegexPatternRector part 2 #7391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/cc @marcreichel let's another try |
TomasVotruba
reviewed
Oct 1, 2025
| /** | ||
| * @var array<string, string> | ||
| */ | ||
| private const COMPLEX_PATTERN_TO_SIMPLE = [ |
Member
There was a problem hiding this comment.
Could you add note about the scoper issue? So we at least know "why" , since there is no test fixture to verify
Member
Author
There was a problem hiding this comment.
The fixture is exists, see https://github.com/rectorphp/rector-src/pull/7390/files#diff-50a42149759f087eb3dce4cbe895b8f759b6e1b26013eb262d8a088c39706e03
It just issue with php-scoper.
I will look if it can simply be handled by double quote.
Member
Author
There was a problem hiding this comment.
Properly resolved with double quoted:
on dev-main rectorphp/rector@d61e2b7
Tested locally, working ok.
I will add the note comment.
Member
Author
There was a problem hiding this comment.
I created PR to add comment about it
This was referenced Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref rectorphp/rector#9395