Incorrect behavior of SimplifyRegexPatternRector

[marcreichel]

Bug Report

The SimplifyRegexPatternRector produces broken regular expressions where the escape character is missing.

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/e0420e6c-273f-42d1-a8e5-3a9020bda3cb

<?php

final class DemoFile
{
    public function run(string $param)
    {
        return preg_match('/^[0-9]+$/', $param);
    }
}

Responsible rules

• SimplifyRegexPatternRector

Expected Behavior

The escape character should be added: '/^\d+$/' instead of '/^d+$/'.

[marcreichel]

It seems, 3ed8e47 has broken the rule because there the escape characters have been removed.

[TomasVotruba]

@marcreichel Thanks for checking. Can you send a fix? 🙏

[samsonasik]

That seems due to bump of php-scoper to 0.18.17, I will look into it to ensure if it can be patched in the rule itself.

[samsonasik]

see

• [CodeQuality] Fix escape character on SimplifyRegexPatternRector rector-src#7390

[samsonasik]

Let's another try

• [CodeQuality] Fix escape character on SimplifyRegexPatternRector part 2 rector-src#7391

[samsonasik]

Resolved at latest dev-main c6d72e9

• [CodeQuality] Fix escape character on SimplifyRegexPatternRector part 2 rector-src#7391

[samsonasik]

Looking for better solution instead of \\\

• Try use double quote on SimplifyRegexPatternRector (part 3) rector-src#7392

[samsonasik]

Properly resolved with double quoted:

• Try use double quote on SimplifyRegexPatternRector (part 3) rector-src#7392

on dev-main d61e2b7

Tested locally, working ok.

[marcreichel]

@samsonasik Nice, thank you very much! 🥳 It is possible to release this as a bug release soon?

[samsonasik]

I talked with @TomasVotruba that the release should be about next week