Skip to content

Conversation

@samsonasik
Copy link
Member

@samsonasik samsonasik commented Sep 29, 2025

@TomasVotruba per discussion on #7365 (comment)

This is make configurable in case you want to consider it, this is default to false so user needs to enable it in the config, via:

$rectorConfig->includePostRectorsInReports(true);

or

return RectorConfig::configure()
      // ...
     ->withIncludePostRectorsInReports(true);

/cc @simonschaufi

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

As I wrote, I want to keep post Rectors as internal separated feature and keep configuration to minimum to make it readable. Adding off/on option here and there would turn into choice paralysis mess.

@simonschaufi
Copy link
Contributor

simonschaufi commented Sep 29, 2025

😢 I'm sad about this decision. Post rectors still change code and are not just an internal rector thing

@TomasVotruba TomasVotruba deleted the make-configurable-report branch September 29, 2025 21:05
@rectorphp rectorphp locked as resolved and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants