-
-
Notifications
You must be signed in to change notification settings - Fork 431
revert adding post rectors to applied rules as not relevant in result #7365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b268cb0 to
bbb3be6
Compare
bbb3be6 to
82aeb38
Compare
|
Instead of reverting it completely, I would at least appreciate a configuration option because I really want to see what is going on. There should be a way to show the post rectors in order to know how to disable them for certain files because I have a scenario where I can't import namespaces neither in php nor in the doc blocks. What do you think about a configuration option or a cli parameter? |
|
@TomasVotruba I agree with @simonschaufi, I will create PR to make it configurable, disable by default. |
|
There is already many options. I want to keep config as simple as it is. |
|
The -@return array<class-string<RectorInterface|PostRectorInterface>>
+@return array<class-string<RectorInterface>>since |
So what do you suggest instead? I would love to hear your opinion how to still display the post rectors if wanted. |
|
@simonschaufi I created new PR: in case @TomasVotruba will consider that |
Partially reverts: https://github.com/rectorphp/rector-src/pull/7304/files
Ref rectorphp/rector#9373
I'm testing this feature and it shows under every single change, as most of changes do include object from time to time.
This is not very helpful, as new users is trying to understand what 5 of those magical post-rules. Also demo link will not work to create test fixture, as exactly 1 rule must be applied.
Autoimport is a standalone features, because of its complexity. It's not a rule per-se.
Saying that, I'm reverting these post rules from being shown in the result, to keep reports nice and tidy to read 👍