Skip to content
/ rector-src Public

Fix RemoveDuplicatedCaseInSwitchRector behavior #7173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 3 commits into from
Aug 25, 2025
Merged

Fix RemoveDuplicatedCaseInSwitchRector behavior #7173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5965fc
Fix `RemoveDuplicatedCaseInSwitchRector` behavior
mspirkov Aug 25, 2025
76ea2b1
fix cs
mspirkov Aug 25, 2025
8d5cd1a
fix and test case
mspirkov Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ composer.lock
# PHPStorm meta files
.idea/

# VS Code files
.vscode

.phpunit.result.cache
# since PHPUnit 10
.phpunit.cache
Expand Down
46 changes: 46 additions & 0 deletions .../Switch_/RemoveDuplicatedCaseInSwitchRector/Fixture/consecutive_equal_case_stmts4.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
<?php

namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;

class ConsecutiveEqualCaseStmts4
{
public function run($name)
{
switch ($name) {
case 'a':
return 'A';
case 'b':
return 'C';
case 'd':
case 'c':
case 'f':
default:
return 'C';
}
}
}

?>
-----
<?php

namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;

class ConsecutiveEqualCaseStmts4
{
public function run($name)
{
switch ($name) {
case 'a':
return 'A';
case 'b':
case 'd':
case 'c':
case 'f':
default:
return 'C';
}
}
}

?>
46 changes: 46 additions & 0 deletions .../Switch_/RemoveDuplicatedCaseInSwitchRector/Fixture/consecutive_equal_case_stmts5.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
<?php

namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;

class ConsecutiveEqualCaseStmts5
{
public function run($name)
{
switch ($name) {
case 'a':
return 'A';
case 'b':
return 'C';
default:
case 'd':
case 'c':
case 'f':
return 'C';
}
}
}

?>
-----
<?php

namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;

class ConsecutiveEqualCaseStmts5
{
public function run($name)
{
switch ($name) {
case 'a':
return 'A';
case 'b':
default:
case 'd':
case 'c':
case 'f':
return 'C';
}
}
}

?>
56 changes: 56 additions & 0 deletions ...Switch_/RemoveDuplicatedCaseInSwitchRector/Fixture/different_indirect_duplicated4.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
<?php

namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;

class DifferentIndirectDuplicated4
{
public function run()
{
switch ($item) {
case 'a':
case 'b':
return 'val1';
case 'c':
return 'val2';
case 'd':
case 'e':
return 'val5';
case 'f':
case 'g':
case 'h':
return 'val2';
case 'i':
return 'val3';
}
}
}

?>
-----
<?php

namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;

class DifferentIndirectDuplicated4
{
public function run()
{
switch ($item) {
case 'a':
case 'b':
return 'val1';
case 'c':
case 'f':
case 'g':
case 'h':
return 'val2';
case 'd':
case 'e':
return 'val5';
case 'i':
return 'val3';
}
}
}

?>
53 changes: 53 additions & 0 deletions ...Switch_/RemoveDuplicatedCaseInSwitchRector/Fixture/different_indirect_duplicated5.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
<?php

namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;

class DifferentIndirectDuplicated5
{
public function run($name)
{
switch ($name) {
case 'a':
return 'A';
case 'b':
return 'C';
case 'd':
case 'c':
case 'f':
return 'C';
case 'e':
return 'A';
default:
return 'C';
case 'i':
return 'A';
}
}
}

?>
-----
<?php

namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;

class DifferentIndirectDuplicated5
{
public function run($name)
{
switch ($name) {
case 'a':
case 'e':
case 'i':
return 'A';
case 'b':
case 'd':
case 'c':
case 'f':
default:
return 'C';
}
}
}

?>
47 changes: 47 additions & 0 deletions ...ctor/Switch_/RemoveDuplicatedCaseInSwitchRector/Fixture/no_stmts_without_comments.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<?php

namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;

class NoStmtsWithoutComments
{
public function run($foo)
{
switch ($foo) {
case 'A':
break;
case 'B':
case 'C':
break;
case 'D':
$type = 'BAR';
break;
case 'E':
case 'F':
default:
break;
}
}
}
-----
<?php

namespace Rector\Tests\DeadCode\Rector\Switch_\RemoveDuplicatedCaseInSwitchRector\Fixture;

class NoStmtsWithoutComments
{
public function run($foo)
{
switch ($foo) {
case 'A':
case 'B':
case 'C':
case 'E':
case 'F':
default:
break;
case 'D':
$type = 'BAR';
break;
}
}
}
Loading