Fix RemoveDuplicatedCaseInSwitchRector behavior#7173
Merged
samsonasik merged 3 commits intorectorphp:mainfrom Aug 25, 2025
Merged
Fix RemoveDuplicatedCaseInSwitchRector behavior#7173samsonasik merged 3 commits intorectorphp:mainfrom
RemoveDuplicatedCaseInSwitchRector behavior#7173samsonasik merged 3 commits intorectorphp:mainfrom
Conversation
samsonasik
approved these changes
Aug 25, 2025
Member
samsonasik
left a comment
samsonasik
left a comment
There was a problem hiding this comment.
Looks good 👍 , let's give it a try
Member
|
Thank you @max-s-lab |
Contributor
|
This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: rectorphp/rector#9329
In this PR, I fixed the behavior of
RemoveDuplicatedCaseInSwitchRector. The existing algorithm seemed very complicated to me, and I couldn't fix it, so I wrote a new one.I hope I haven't missed any test cases. I would appreciate any suggestions for adding test cases.