Skip to content
/ rector-src Public

[Scoper] Remove PHP_VERSION_ID < 70400 check on scoper.php #7162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samsonasik merged 3 commits into from
Aug 21, 2025
Merged

[Scoper] Remove PHP_VERSION_ID < 70400 check on scoper.php #7162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7637665
[Scoper] Remove PHP_VERSION_ID < 70400 check on scoper.php
samsonasik Aug 21, 2025
4aecddd
Merge branch 'main' of github.com:rectorphp/rector-src into scoper-patch
samsonasik Aug 21, 2025
a8fbe10
[ci-review] Rector Rectify
actions-user Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rules/CodeQuality/Rector/Class_/StaticToSelfStaticMethodCallOnFinalClassRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,10 @@ public function refactor(Node $node): ?Class_
return null;
}

$methodReflection = $classReflection->getNativeMethod($methodName);
$extendedMethodReflection = $classReflection->getNativeMethod($methodName);

// avoid overlapped change
if (! $methodReflection->isStatic()) {
if (! $extendedMethodReflection->isStatic()) {
return null;
}

Expand Down
20 changes: 0 additions & 20 deletions scoper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,25 +142,5 @@ static function (string $filePath, string $prefix, string $content): string {

return str_replace("'" . $prefix . '\\', "'\\", $content);
},

static function (string $filePath, string $prefix, string $content): string {
if (! \str_ends_with($filePath, 'vendor/nette/utils/src/Utils/Strings.php')) {
return $content;
}

# see https://github.com/rectorphp/rector/issues/8564
return str_replace(
'return self::pcre(\'preg_replace_callback\', [$pattern, $replacement, $subject, $limit, 0, $flags]);',
<<<'CODE_REPLACE'
if (PHP_VERSION_ID < 70400) {
return self::pcre('preg_replace_callback', [$pattern, $replacement, $subject, $limit]);
}

return self::pcre('preg_replace_callback', [$pattern, $replacement, $subject, $limit, 0, $flags]);
CODE_REPLACE
,
$content
);
},
],
];
Loading