Skip to content

[Scoper] Remove PHP_VERSION_ID < 70400 check on scoper.php#7162

Merged
samsonasik merged 3 commits intomainfrom
scoper-patch
Aug 21, 2025
Merged

[Scoper] Remove PHP_VERSION_ID < 70400 check on scoper.php#7162
samsonasik merged 3 commits intomainfrom
scoper-patch

Conversation

@samsonasik
Copy link
Member

This was hack to handle issue:

since rector scoped now require php 7.4, this hack is not needed.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit bd6fe4f into main Aug 21, 2025
49 checks passed
@samsonasik samsonasik deleted the scoper-patch branch August 21, 2025 13:16
@samsonasik
Copy link
Member Author

samsonasik commented Aug 21, 2025

For note: we may need to have special downgrade rule for this for to downgrade to < 7.4 compatible code, for example, on easy-coding-standard, which uses 7.2 have the same code, which if on specific circumstance executed, it will error:

https://github.com/easy-coding-standard/easy-coding-standard/blob/4b90f2b6efed9508000968eac2397ac7aff34354/vendor/nette/utils/src/Utils/Strings.php#L566

@github-actions
Copy link
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants