Skip to content

[rcore] refactor possible data loss on FileMove() #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raysan5 merged 1 commit into from
Mar 23, 2026
Merged

[rcore] refactor possible data loss on FileMove() #5682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/rcore.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2274,14 +2274,16 @@ int FileCopy(const char *srcPath, const char *dstPath)
// NOTE: If dst directories do not exists they are created
int FileMove(const char *srcPath, const char *dstPath)
{
int result = 0;
int result = -1;

if (FileExists(srcPath))
{
FileCopy(srcPath, dstPath);
FileRemove(srcPath);
if (FileCopy(srcPath, dstPath) == 0)
result = FileRemove(srcPath);
else
TRACELOG(LOG_WARNING, "FILEIO: [%s] Failed to copy file to [%s]", srcPath, dstPath);
}
else result = -1;
else TRACELOG(LOG_WARNING, "FILEIO: [%s] Source file does not exist", srcPath);

return result;
}
Expand Down