[rcore] refactor possible data loss on FileMove()#5682
Open
lvntky wants to merge 1 commit intoraysan5:masterfrom
Open
[rcore] refactor possible data loss on FileMove()#5682lvntky wants to merge 1 commit intoraysan5:masterfrom
lvntky wants to merge 1 commit intoraysan5:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FireRemove() function was called without any checks. If FileCopy encountered an error for any reason, FileRemove() would irreversibly delete the copied data.
Also
resultwas initialized to0(success) making the returnvalue meaningless when
FileCopy()orFileRemove()failed.Fix by checking
FileCopy()return value before removing the sourcefile, and initializing
resultto-1.