[FEA] Improve kmeans::fit_predict by keeping predicted labels from fit#1939
Draft
lowener wants to merge 1 commit intorapidsai:mainfrom
Draft
[FEA] Improve kmeans::fit_predict by keeping predicted labels from fit#1939lowener wants to merge 1 commit intorapidsai:mainfrom
lowener wants to merge 1 commit intorapidsai:mainfrom
Conversation
Signed-off-by: Mickael Ide <mide@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I remove the additionnal
predict()call present inkmeans::fit_predict(), to instead keep the labels already computed infit().I moved the public API function
fit_predictandfitin the same compilation unit since they both use the samedetail::fitbut with different parameters now.Some unnecessary template instantiation are removed as well.
Still WIP because I need to do the same improvement in kmeans_balanced