Skip to content

Fix missing error handling in LLM response stream iteration #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix missing error handling in LLM response stream iteration #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ff93a2
Initial plan
Copilot Nov 16, 2025
c8a21ea
fix: add error handling for LLM response stream in summarizer
Copilot Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions adk-code/internal/session/compaction/summarizer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ func (ls *LLMSummarizer) Summarize(
Contents: []*genai.Content{
{
Role: "user",
Parts: []genai.Part{
genai.Text(prompt),
Parts: []*genai.Part{
{Text: prompt},
},
},
},
Expand All @@ -59,7 +59,10 @@ func (ls *LLMSummarizer) Summarize(
var usageMetadata *genai.GenerateContentResponseUsageMetadata

responseStream := ls.llm.GenerateContent(ctx, llmRequest, false)
for resp := range responseStream {
for resp, err := range responseStream {
if err != nil {
return nil, fmt.Errorf("LLM generation error: %w", err)
}
if resp == nil {
continue
}
Expand Down