Skip to content

fix(event): Registry data buffer bound checks #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rabbitstack wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −3
Open

fix(event): Registry data buffer bound checks #600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 32 additions & 3 deletions pkg/event/param_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,11 +540,40 @@
case registry.BINARY:
e.AppendParam(params.RegData, params.Binary, b)
case registry.DWORD:
e.AppendParam(params.RegData, params.Uint32, binary.LittleEndian.Uint32(b))
var v uint32
switch len(b) {
case 4:
v = binary.LittleEndian.Uint32(b)
case 2:
v = uint32(binary.LittleEndian.Uint16(b))
case 1:
v = uint32(b[0])
}
e.AppendParam(params.RegData, params.Uint32, v)
case registry.DWORD_BIG_ENDIAN:
e.AppendParam(params.RegData, params.Uint32, binary.BigEndian.Uint32(b))
var v uint32
switch len(b) {
case 4:
v = binary.BigEndian.Uint32(b)
case 2:
v = uint32(binary.BigEndian.Uint32(b))

Check failure on line 559 in pkg/event/param_windows.go

View workflow job for this annotation

GitHub Actions / lint 

unnecessary conversion (unconvert)
case 1:
v = uint32(b[0])
}
e.AppendParam(params.RegData, params.Uint32, v)
case registry.QWORD:
e.AppendParam(params.RegData, params.Uint64, binary.LittleEndian.Uint64(b))
var v uint64
switch len(b) {
case 8:
v = binary.LittleEndian.Uint64(b)
case 4:
v = uint64(binary.LittleEndian.Uint32(b))
case 2:
v = uint64(binary.LittleEndian.Uint16(b))
case 1:
v = uint64(b[0])
}
e.AppendParam(params.RegData, params.Uint64, v)
}
}
case CreateFile:
Expand Down
Loading