Skip to content

fix(event): Registry data buffer bound checks#600

Open
rabbitstack wants to merge 1 commit intomasterfrom
regsetvalue-data-bound-checks
Open

fix(event): Registry data buffer bound checks#600
rabbitstack wants to merge 1 commit intomasterfrom
regsetvalue-data-bound-checks

Conversation

@rabbitstack
Copy link
Owner

What is the purpose of this PR / why it is needed?

In some occasions, the registry data buffer is provided without enough length to satisfy the underlying value type. To prevent panics, when converting the buffer to an integer data type, incorporate bound checks.

What type of change does this PR introduce?


Uncomment one or more /kind <> lines:

/kind feature (non-breaking change which adds functionality)

/kind bug-fix (non-breaking change which fixes an issue)

/kind refactor (non-breaking change that restructures the code, while not changing the original functionality)

/kind breaking (fix or feature that would cause existing functionality to not work as expected

/kind cleanup

/kind improvement

/kind design

/kind documentation

/kind other (change that doesn't pertain to any of the above categories)

Any specific area of the project related to this PR?


Uncomment one or more /area <> lines:

/area instrumentation

/area telemetry

/area rule-engine

/area filters

/area yara

/area event

/area captures

/area alertsenders

/area outputs

/area rules

/area filaments

/area config

/area cli

/area tests

/area ci

/area build

/area docs

/area deps

/area evasion

/area other

Special notes for the reviewer


Does this PR introduce a user-facing change?


In some occasions, the registry data buffer is provided
without enough length to satisfy the underlying value
type. To prevent panics, when converting the buffer to
an integer data type, incorporate bound checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant