Add a hint if check_win() email is not as desired

R/check-win.R

@@ -118,9 +118,7 @@ check_win <- function(
     ))
 
     email <- maintainer(pkg)$email
-    if (interactive() && yesno("Email results to {.strong {email}}?")) {
-      return(invisible())
-    }
+    confirm_maintainer_email(email)
   }
 
   built_path <- pkgbuild::build(
@@ -154,6 +152,24 @@ check_win <- function(
   invisible()
 }
 
+confirm_maintainer_email <- function(email, call = parent.frame()) {
+  if (!rlang::is_interactive()) {
+    return(FALSE)
+  }
+
+  if (!yesno("Email results to {.strong {email}}?")) {
+    return()
+  }
+
+  cli::cli_abort(
+    c(
+      "User declined upload.",
+      i = "Use `email = {.str your email}` to override."
+    ),
+    call = call
+  )
+}
+
 change_maintainer_email <- function(path, email, call = parent.frame()) {
   desc <- desc::desc(file = path)
 

tests/testthat/_snaps/check-win.md

@@ -14,3 +14,14 @@
       Error:
       ! DESCRIPTION can't use Maintainer field when changing `email`
 
+# email confirmation gives useful advice
+
+    Code
+      confirm_maintainer_email("hadley@posit.co")
+    Message
+      Email results to hadley@posit.co?
+    Condition
+      Error:
+      ! User declined upload.
+      i Use `email = "your email"` to override.
+

tests/testthat/test-check-win.R

@@ -14,3 +14,13 @@ test_that("change_maintainer_email checks fields", {
   desc$write(path)
   expect_snapshot(change_maintainer_email(path, "x@example.com"), error = TRUE)
 })
+
+test_that("email confirmation gives useful advice", {
+  withr::local_options(rlang_interactive = TRUE)
+  local_mocked_bindings(yesno = function(msg) {
+    cli::cli_inform(msg, .envir = parent.frame())
+    TRUE
+  })
+
+  expect_snapshot(confirm_maintainer_email("hadley@posit.co"), error = TRUE)
+})