Skip to content

docs(tui/remote): justify unused_imports allow on pub(super) re-exports (#103) #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quangdang46 merged 1 commit into from
May 22, 2026
+6 −1
Merged

docs(tui/remote): justify unused_imports allow on pub(super) re-exports (#103) #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/CODE_QUALITY_TODO.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ Generated from `docs/CODE_QUALITY_AUDIT_2026-04-18.md`. This section enumerates
- [ ] Remove or justify suppressions in `src/server/comm_sync.rs` (clippy::too_many_arguments)
- [ ] Remove or justify suppressions in `src/server/debug_swarm_write.rs` (clippy::too_many_arguments)
- [ ] Remove or justify suppressions in `src/server/startup_tests.rs` (unused_mut)
- [ ] Remove or justify suppressions in `src/tui/app/remote.rs` (unused_imports, unused_imports)
- [x] Remove or justify suppressions in `src/tui/app/remote.rs` (unused_imports, unused_imports)
- [ ] Remove or justify suppressions in `src/tui/app/state_ui.rs` (unused_mut)
- [ ] Remove or justify suppressions in `src/tui/info_widget.rs` (deprecated)

Expand Down
5 changes: 5 additions & 0 deletions src/tui/app/remote.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ mod workspace;
use queue_recovery::{recover_local_interleave_to_queue, recover_stranded_soft_interrupts};
// Re-export for sibling modules and tests that access reconnect state and helpers
// through `super::remote::*` without reaching into private submodules directly.
// `#[allow(unused_imports)]` is required because rustc flags re-exports as unused
// when none of the names are referenced within *this* module; they are consumed by
// sibling modules and the compiler does not look across module boundaries here.
#[allow(unused_imports)]
pub(super) use reconnect::{
ConnectOutcome, PostConnectOutcome, ReloadReconnectHints, RemoteRunState, connect_with_retry,
Expand All @@ -42,6 +45,8 @@ use workspace::{handle_workspace_command, handle_workspace_navigation_key};

// Re-export the remote input dispatch helpers for sibling modules/tests that go
// through the `remote` facade instead of private submodule paths.
// Same rationale as above: `#[allow(unused_imports)]` silences the false-positive
// lint for re-exports that are only consumed outside this module.
#[allow(unused_imports)]
pub(super) use input_dispatch::{
apply_remote_transcript_event, apply_transcript_event, begin_remote_send,
Expand Down