docs(tui/remote): justify unused_imports allow on pub(super) re-exports (#103)#178
Open
quangdang46 wants to merge 1 commit into
Open
docs(tui/remote): justify unused_imports allow on pub(super) re-exports (#103)#178quangdang46 wants to merge 1 commit into
quangdang46 wants to merge 1 commit into
Conversation
The two #[allow(unused_imports)] suppressions on `pub(super) use` blocks in src/tui/app/remote.rs are load-bearing: rustc flags re-exports as unused when their names aren't referenced inside the same module, but sibling modules and tests do consume them through `super::remote::*`. Removing the allow would generate noise on every build. Replace the implicit terse comment with an explicit explanation of the cross-module-boundary lint behavior so future contributors don't try to remove the allow. Tick the matching item in docs/CODE_QUALITY_TODO.md. Ports upstream PR 1jehuang#125. Closes #103
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The two
#[allow(unused_imports)]suppressions onpub(super) useblocks insrc/tui/app/remote.rsare load-bearing: rustc flags re-exports as unused when none of the names are referenced inside the same module, but sibling modules and tests consume them throughsuper::remote::*.This addresses issue #103: #103
Changes
#[allow(unused_imports)]sites.Tests
cargo fmt --checkclean; comment-only change, no behavior change.Notes
Ports upstream PR 1jehuang#125.