Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions arch/arm64/boot/dts/qcom/lemans-evk-mezzanine-qps615.dtsi
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
// SPDX-License-Identifier: BSD-3-Clause
/*
* Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
*/

#include <dt-bindings/interrupt-controller/irq.h>

&eth0_pci {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you use node name directly and avoid adding labelling

pinctrl-names = "default";
pinctrl-0 = <&aqr_intn_wol_sig>;
phy-rst-som-gpios = <&tlmm 76 GPIO_ACTIVE_HIGH>;
interrupts-extended = <&tlmm 56 IRQ_TYPE_EDGE_FALLING>;
interrupt-names = "wol_irq";
qcom,always-on-supply;
qcom,phy-rst-delay-us = <221000>;

qcom,iommu-group = <&eth0_pci_iommu_group>;
eth0_pci_iommu_group: eth0_pci_iommu_group {
qcom,iommu-dma = "atomic";
};
};

&eth1_pci {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

pinctrl-names = "default";
pinctrl-0 = <&napa_intn_wol_sig>;
phy-rst-som-gpios = <&tlmm 77 GPIO_ACTIVE_HIGH>;
interrupts-extended = <&tlmm 57 IRQ_TYPE_EDGE_FALLING>;
interrupt-names = "wol_irq";
qcom,always-on-supply;
qcom,phy-rst-delay-us = <20000>;

qcom,iommu-group = <&eth1_pci_iommu_group>;
eth1_pci_iommu_group: eth1_pci_iommu_group {
qcom,iommu-dma = "atomic";
};
};

&tlmm {
qps615_intn_wol {
aqr_intn_wol_sig: aqr-intn-wol-sig {
pins = "gpio56";
function = "gpio";
input-enable;
bias-disable;
};
napa_intn_wol_sig: napa-intn-wol-sig {
pins = "gpio57";
function = "gpio";
input-enable;
bias-disable;
};
};
};
6 changes: 4 additions & 2 deletions arch/arm64/boot/dts/qcom/lemans-evk-mezzanine.dtso
Original file line number Diff line number Diff line change
Expand Up @@ -247,15 +247,15 @@
ranges;
bus-range = <0x5 0xff>;

pci@0,0 {
eth0_pci: pci@0,0 {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you need to add label ?

reg = <0x50000 0x0 0x0 0x0 0x0>;
#address-cells = <3>;
#size-cells = <2>;
device_type = "pci";
ranges;
};

pci@0,1 {
eth1_pci: pci@0,1 {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here ?

reg = <0x50100 0x0 0x0 0x0 0x0>;
#address-cells = <3>;
#size-cells = <2>;
Expand Down Expand Up @@ -299,3 +299,5 @@
power-source = <0>;
};
};

#include "lemans-evk-mezzanine-qps615.dtsi"
54 changes: 54 additions & 0 deletions arch/arm64/boot/dts/qcom/monaco-evk-mezzanine-qps615.dtsi
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
// SPDX-License-Identifier: BSD-3-Clause
/*
* Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
*/

#include <dt-bindings/interrupt-controller/irq.h>

&eth0_pci {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

pinctrl-names = "default";
pinctrl-0 = <&aqr_intn_wol_sig>;
phy-rst-som-gpios = <&tlmm 10 GPIO_ACTIVE_HIGH>;
interrupts-extended = <&tlmm 40 IRQ_TYPE_EDGE_FALLING>;
interrupt-names = "wol_irq";
qcom,always-on-supply;
qcom,phy-rst-delay-us = <221000>;

qcom,iommu-group = <&eth0_pci_iommu_group>;
eth0_pci_iommu_group: eth0_pci_iommu_group {
qcom,iommu-dma = "atomic";
};
};

&eth1_pci {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

pinctrl-names = "default";
pinctrl-0 = <&napa_intn_wol_sig>;
phy-rst-som-gpios = <&expander5 0 GPIO_ACTIVE_HIGH>;
interrupts-extended = <&tlmm 39 IRQ_TYPE_EDGE_FALLING>;
interrupt-names = "wol_irq";
qcom,always-on-supply;
qcom,phy-rst-delay-us = <20000>;

qcom,iommu-group = <&eth1_pci_iommu_group>;
eth1_pci_iommu_group: eth1_pci_iommu_group {
qcom,iommu-dma = "atomic";
};
};

&tlmm {
qps615_intn_wol {
aqr_intn_wol_sig: aqr-intn-wol-sig {
pins = "gpio40";
function = "gpio";
input-enable;
bias-disable;
};

napa_intn_wol_sig: napa-intn-wol-sig {
pins = "gpio39";
function = "gpio";
input-enable;
bias-disable;
};
};
};
6 changes: 4 additions & 2 deletions arch/arm64/boot/dts/qcom/monaco-evk-mezzanine.dtso
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,15 @@
ranges;
bus-range = <0x5 0xff>;

pci@0,0 {
eth0_pci: pci@0,0 {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you will not need then to add label

reg = <0x50000 0x0 0x0 0x0 0x0>;
#address-cells = <3>;
#size-cells = <2>;
device_type = "pci";
ranges;
};

pci@0,1 {
eth1_pci: pci@0,1 {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also can be removed

reg = <0x50100 0x0 0x0 0x0 0x0>;
#address-cells = <3>;
#size-cells = <2>;
Expand All @@ -187,3 +187,5 @@
power-source = <0>;
};
};

#include "monaco-evk-mezzanine-qps615.dtsi"
84 changes: 84 additions & 0 deletions arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-qps615.dtsi
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
// SPDX-License-Identifier: BSD-3-Clause
/*
* Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
*/

/ {
qep_vreg: qep_vreg {
compatible = "regulator-fixed";
regulator-name = "qep_vreg";
gpio = <&pm7325_gpios 8 0>;
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
enable-active-high;
};

aqr_vreg: aqr_vreg {
compatible = "regulator-fixed";
regulator-name = "aqr_vreg";
gpio = <&pm7250b_gpios 4 0>;
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
enable-active-high;
};
};

&eth0_pci {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label

pinctrl-names = "default";
pinctrl-0 = <&aqr_intn_wol_sig>;
qcom,phy-rst-gpio-id = <0>;
interrupts-extended = <&tlmm 141 IRQ_TYPE_EDGE_FALLING>;
interrupt-names = "wol_irq";
phy-supply = <&aqr_vreg>;
qcom,phy-rst-delay-us = <221000>;

qcom,iommu-group = <&eth0_pci_iommu_group>;
eth0_pci_iommu_group: eth0_pci_iommu_group {
qcom,iommu-dma = "atomic";
};
};

&eth1_pci {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

label

pinctrl-names = "default";
pinctrl-0 = <&napa_intn_wol_sig>;
qcom,phy-rst-gpio-id = <1>;
interrupts-extended = <&tlmm 101 IRQ_TYPE_EDGE_FALLING>;
interrupt-names = "wol_irq";
phy-supply = <&qep_vreg>;
qcom,phy-rst-delay-us = <20000>;

qcom,iommu-group = <&eth1_pci_iommu_group>;
eth1_pci_iommu_group: eth1_pci_iommu_group {
qcom,iommu-dma = "atomic";
};
};

&tlmm {
qps615_intn_wol {
aqr_intn_wol_sig: aqr_intn_wol_sig {
mux {
pins = "gpio141";
function = "gpio";
};

config {
pins = "gpio141";
input-enable;
bias-disable;
};
};

napa_intn_wol_sig: napa_intn_wol_sig {
mux {
pins = "gpio101";
function = "gpio";
};

config {
pins = "gpio101";
input-enable;
bias-disable;
};
};
};
};
6 changes: 4 additions & 2 deletions arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
Original file line number Diff line number Diff line change
Expand Up @@ -920,15 +920,15 @@
ranges;
bus-range = <0x5 0xff>;

pci@0,0 {
eth0_pci: pci@0,0 {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

reg = <0x50000 0x0 0x0 0x0 0x0>;
#address-cells = <3>;
#size-cells = <2>;
device_type = "pci";
ranges;
};

pci@0,1 {
eth1_pci: pci@0,1 {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

reg = <0x50100 0x0 0x0 0x0 0x0>;
#address-cells = <3>;
#size-cells = <2>;
Expand Down Expand Up @@ -1818,3 +1818,5 @@
compatible = "qcom,qcm6490-lpassaudiocc";
/delete-property/ power-domains;
};

#include "qcs6490-rb3gen2-qps615.dtsi"