NXP backend: Add DetailedGraphVerifier for strict checking of delegated nodes.#19327
Open
MartinPavella wants to merge 3 commits intopytorch:mainfrom
Conversation
MartinPavella
added
module: nxp
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19327
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 Unrelated FailuresAs of commit a58fcf1 with merge base 48a8d58 ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Collaborator
Author
|
This PR is based on another one: #19272. Please review that one first. |
novak-vaclav
approved these changes
May 6, 2026
Contributor
novak-vaclav
left a comment
novak-vaclav
left a comment
There was a problem hiding this comment.
Two nits, otherwise LGTM. Good work! 😊
| exp_num_delegate_call_nodes=1, # Delegated AvgPool. | ||
| exp_non_delegated_nodes=[], | ||
| ) | ||
| graph_verifier = DetailedGraphVerifier({AvgPool2D: 1}, {}, mocker) |
Contributor
There was a problem hiding this comment.
nit: I would prefer that names of the arguments are used explicitly, just like before with BaseGraphVerifier, because this way I do not know if AvgPool2D should be delegated or not.
Like this:
graph_verifier = DetailedGraphVerifier(
expected_delegated_ops={AvgPool2D: 1},
expected_non_delegated_ops={},
mocker
)
Collaborator
Author
There was a problem hiding this comment.
Good point. I will update it.
MartinPavella
force-pushed
the
nxg01483/EIEX-902-create-a-graphverifier-with-strict-operator-checking
branch
from
045ddec to
a58fcf1
Compare
roman-janik-nxp
approved these changes
May 6, 2026
| ): | ||
| """Initializes the DetailedGraphVerifier and patches NeutronPartitioner.partition() to capture node state. | ||
|
|
||
| :param expected_delegated_ops: Dictionary mapping operators to their expected delegation count |
Collaborator
There was a problem hiding this comment.
Why not use NonDelegatedNode?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The new DetailedGraphVerifier allows us to test for exact delegated and non-delegated nodes in NXP tests. This should improve the reliability of the tests,
Test plan
Tested by MaxPool and AvgPool tests.
cc @robert-kalmar @JakeStevens @digantdesai