NXP backend - added support for aten.abs using the new Neutron flow#19328
Open
novak-vaclav wants to merge 4 commits intopytorch:mainfrom
Open
NXP backend - added support for aten.abs using the new Neutron flow#19328novak-vaclav wants to merge 4 commits intopytorch:mainfrom
aten.abs using the new Neutron flow#19328novak-vaclav wants to merge 4 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19328
Note: Links to docs will display an error until the docs builds have been completed. ❌ 11 Awaiting Approval, 1 New FailureAs of commit 420ab94 with merge base 48a8d58 ( AWAITING APPROVAL - The following workflows need approval before CI can run:
NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
Author
|
@pytorchbot label "module: nxp" |
Contributor
Author
|
@pytorchbot label "release notes: nxp" |
pytorch-bot
Bot
added
module: nxp
Contributor
There was a problem hiding this comment.
Pull request overview
Adds aten.abs delegation support for the NXP backend when using the new Neutron-C (MLIR-based) flow, and expands test coverage to exercise both legacy and new-flow behavior.
Changes:
- Added new-flow target support gating for
aten.abs(currently limited to QDQ quantizedint8/uint8) in the Abs node converter. - Refactored/extended
test_abs_converter.pyto split legacy vs new Neutron flow tests and add NSYS-based lower/run/compare coverage for the new flow. - Updated NXP copyright headers to include 2026.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| backends/nxp/tests/ir/converter/node_converter/test_abs_converter.py | Splits legacy/new-flow tests and adds NSYS-based new-flow runtime validation for abs (including a conv+abs partitioning case). |
| backends/nxp/backend/ir/converter/node_converters/ops_converters/abs_converter.py | Adds new-flow target support checks for abs based on QDQ quantized IO dtype (int8/uint8). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
novak-vaclav
force-pushed
the
feature/EIEX-849-add-abs-support-using-new-neutron-flow
branch
from
ec37498 to
7f474aa
Compare
novak-vaclav
force-pushed
the
feature/EIEX-849-add-abs-support-using-new-neutron-flow
branch
from
7f474aa to
420ab94
Compare
Contributor
Author
|
Rebased onto #19327 Please review @MartinPavella |
Comment on lines
446
to
+447
| if not _is_quantize(quantize_node := users[0]): | ||
| # Broken QDQ schema. |
|
|
||
| tflite_flatbuffers_model, io_formats = converter_spy.spy_return | ||
| exported_program: ExportedProgram = converter_spy.call_args.args[1] | ||
| tflite_flatbuffers_model, io_formats = converter_spy.spy_return |
Comment on lines
27
to
+33
| Slice = exir_ops.edge.aten.slice.Tensor | ||
| SliceCopy = exir_ops.edge.aten.slice_copy.Tensor | ||
| Softmax = exir_ops.edge.aten._softmax.default | ||
| Squeeze = exir_ops.edge.aten.squeeze.default | ||
| SqueezeDim = exir_ops.edge.aten.squeeze.dim | ||
| SqueezeDims = exir_ops.edge.aten.squeeze.dims | ||
| Relu = exir_ops.edge.aten.relu.default |
| self.expected_delegated_ops = expected_delegated_ops | ||
| self.expected_non_delegated_ops = expected_non_delegated_ops | ||
|
|
||
| self.ops_to_ignore = ops_to_ignore or self.default_ops_to_ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added support for
aten.absusing new Neutron flow.Test plan
tests can be manually run using
pytest -c /dev/null backends/nxp/tests/cc @robert-kalmar @JakeStevens @digantdesai @MartinPavella