[RFCT] clk and removal#95
Open
rgiunti wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the latch clock generation in
vregfile.svby replacing the per-celltc_clk_and2between row and column clocks with a cascadedtc_clk_gatingstructure. The functional behavior is unchanged.Motivation
While the current implementation works, AND-ing two clock signals is generally considered a pattern that requires extra care in the backend flow (possible narrow glitches, some lint/CDC tools may give high-severity warnings).
Changes
Column-level
tc_clk_gatingis now driven byrow_clk[row]as its input clock. This produces a per-cell gated clockcol_clk[row][b]directly, with no AND of clocks.Notes
The proposed changes have been simulated with a local CI based on Questasim and synthesized with Synopsys DC in GF22.