Fix react-19 external anchor replacement in AnchoredOverlay and share Vitest setup#7820
Fix react-19 external anchor replacement in AnchoredOverlay and share Vitest setup#7820
Conversation
Agent-Logs-Url: https://github.com/primer/react/sessions/6f872a32-6ca6-4638-b31e-81b5134c5538 Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Agent-Logs-Url: https://github.com/primer/react/sessions/6f872a32-6ca6-4638-b31e-81b5134c5538 Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Agent-Logs-Url: https://github.com/primer/react/sessions/6f872a32-6ca6-4638-b31e-81b5134c5538 Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Agent-Logs-Url: https://github.com/primer/react/sessions/6f872a32-6ca6-4638-b31e-81b5134c5538 Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
|
|
|
@copilot fix CI, it is currently broken. Don't submit changes for review until CI is green |
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Fixed in b0e2fcd. Local validation is green ( |
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Addressed in 9ebb459. Added a shared |
Changelog
New
@primer/vitest-configworkspace package for the common Vitest console-enforcement setup.config/vitest/setup.jsentrypoints so each package can consume the shared Vitest setup without relying on a top-level setup script path.Changed
AnchoredOverlayto re-sync CSS anchor-positioning state when an externalanchorRefDOM node is replaced while the overlay remains open.renderAnchorbehavior while fixing the React 19 external-anchor remount case that causedanchor-nameandposition-anchorto fall out of sync.Removed
script/vitest/setup.ts.Rollout strategy
Testing & Reviewing
test (react-19)job logs for run25577112553, job75087602292.packages/react/src/ActionMenu/ActionMenu.test.tsx.AnchoredOverlayfix with:npx vitest --config vitest.config.browser.mts run src/AnchoredOverlay/AnchoredOverlay.test.tsxnpx vitest --config vitest.config.browser.mts run src/ActionMenu/ActionMenu.test.tsxnpm run lint -- --no-cachenpm run type-checkcd packages/styled-react && npx vitest --run src/__tests__/exports.test.tscd packages/react && npx vitest --config vitest.config.browser.mts run src/AnchoredOverlay/AnchoredOverlay.test.tsxMerge checklist