Skip to content

Comments

Rename variable to match feature flag name: InsideDialog not InsidePortal#7565

Merged
francinelucca merged 2 commits intochore/action-menu-display-in-viewport-enhancementfrom
copilot/sub-pr-7524
Feb 18, 2026
Merged

Rename variable to match feature flag name: InsideDialog not InsidePortal#7565
francinelucca merged 2 commits intochore/action-menu-display-in-viewport-enhancementfrom
copilot/sub-pr-7524

Conversation

Copy link
Contributor

Copilot AI commented Feb 18, 2026

Addresses review feedback from parent PR #7524 to rename featureFlagDisplayInViewportInsidePortal to featureFlagDisplayInViewportInsideDialog.

Changes

  • Variable name now matches feature flag primer_react_action_menu_display_in_viewport_inside_dialog
  • Accurately reflects that the feature detects ActionMenu inside Dialog, not Portal

Changelog

Changed

  • Renamed featureFlagDisplayInViewportInsidePortal to featureFlagDisplayInViewportInsideDialog in ActionMenu.tsx

Rollout strategy

  • None; variable rename only, no API or behavior changes

Testing & Reviewing

No functional changes. Variable rename only for consistency with feature flag naming.

Merge checklist


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2026

⚠️ No Changeset found

Latest commit: 7a37fe6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
Copilot AI changed the title [WIP] Update ActionMenu rendering in Dialog based on review feedback Rename variable to match feature flag name: InsideDialog not InsidePortal Feb 18, 2026
Copilot AI requested a review from francinelucca February 18, 2026 04:50
@francinelucca francinelucca marked this pull request as ready for review February 18, 2026 04:53
@francinelucca francinelucca requested a review from a team as a code owner February 18, 2026 04:53
@francinelucca francinelucca merged commit ce6f502 into chore/action-menu-display-in-viewport-enhancement Feb 18, 2026
39 of 41 checks passed
@francinelucca francinelucca deleted the copilot/sub-pr-7524 branch February 18, 2026 04:53
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants